From cb27dc8a217680f2f7a15d35e081469b250000a4 Mon Sep 17 00:00:00 2001
From: glaszig <mail@glasz.org>
Date: Fri, 23 Jun 2023 17:17:10 -0300
Subject: [PATCH] allow inheriting from TimeSeries class

---
 src/TimeSeries.php               |  6 ++---
 tests/Integration/ExtendTest.php | 40 ++++++++++++++++++++++++++++++++
 2 files changed, 43 insertions(+), 3 deletions(-)
 create mode 100644 tests/Integration/ExtendTest.php

diff --git a/src/TimeSeries.php b/src/TimeSeries.php
index 37d5404..99bea1d 100644
--- a/src/TimeSeries.php
+++ b/src/TimeSeries.php
@@ -9,7 +9,7 @@
 use Palicao\PhpRedisTimeSeries\Exception\RedisClientException;
 use RedisException;
 
-final class TimeSeries
+class TimeSeries
 {
     public const DUPLICATE_POLICY_BLOCK = 'BLOCK';
     public const DUPLICATE_POLICY_FIRST = 'FIRST';
@@ -18,7 +18,7 @@ final class TimeSeries
     public const DUPLICATE_POLICY_MAX = 'MAX';
     public const DUPLICATE_POLICY_SUM = 'SUM';
 
-    private const DUPLICATE_POLICIES = [
+    protected const DUPLICATE_POLICIES = [
         self::DUPLICATE_POLICY_BLOCK,
         self::DUPLICATE_POLICY_FIRST,
         self::DUPLICATE_POLICY_LAST,
@@ -29,7 +29,7 @@ final class TimeSeries
 
 
     /** @var RedisClientInterface */
-    private $redis;
+    protected $redis;
 
     /**
      * @param RedisClientInterface $redis
diff --git a/tests/Integration/ExtendTest.php b/tests/Integration/ExtendTest.php
new file mode 100644
index 0000000..6a4d754
--- /dev/null
+++ b/tests/Integration/ExtendTest.php
@@ -0,0 +1,40 @@
+<?php
+/* @noinspection PhpUnhandledExceptionInspection */
+
+declare(strict_types=1);
+
+namespace Palicao\PhpRedisTimeSeries\Tests\Integration;
+
+use Palicao\PhpRedisTimeSeries\Client\RedisClient;
+use Palicao\PhpRedisTimeSeries\Client\RedisConnectionParams;
+use Palicao\PhpRedisTimeSeries\TimeSeries;
+use PHPUnit\Framework\TestCase;
+use Redis;
+
+class MyTimeSeries extends TimeSeries
+{
+    public function getRedis()
+    {
+        return $this->redis;
+    }
+}
+
+class ExtendTest extends TestCase
+{
+    private $redisClient;
+    private $sut;
+
+    public function setUp(): void
+    {
+        $host = getenv('REDIS_HOST') ?: 'php-rts-redis';
+        $port = getenv('REDIS_PORT') ? (int) getenv('REDIS_PORT') : 6379;
+        $connectionParams = new RedisConnectionParams($host, $port);
+        $this->redisClient = new RedisClient(new Redis(), $connectionParams);
+        $this->sut = new MyTimeSeries($this->redisClient);
+    }
+
+    public function testRedisPropertyScope(): void
+    {
+        self::assertSame($this->redisClient, $this->sut->getRedis());
+    }
+}