Cleanups

Author: rhshadrach

pandas/core/apply.py

@@ -637,7 +637,6 @@ def wrap_results_dict_like(
                 results,
                 axis=axis,
                 keys=keys_to_use,
-                sort=False,
             )
         elif any(is_ndframe):
             # There is a mix of NDFrames and scalars

pandas/core/indexes/api.py

@@ -204,7 +204,7 @@ def union_indexes(indexes, sort: bool | None | lib.NoDefault = True) -> Index:
     if len(indexes) == 1:
         result = indexes[0]
         if isinstance(result, list):
-            if not sort:
+            if not sort or sort is lib.no_default:
                 result = Index(result)
             else:
                 result = Index(sorted(result))

pandas/core/reshape/concat.py

@@ -434,6 +434,8 @@ def concat(
                     "silence this message."
                 )
                 warnings.warn(msg, Pandas4Warning, stacklevel=find_stack_level())
+        else:
+            sort = False
     else:
         if not is_bool(sort):
             raise ValueError(

pandas/tests/reshape/merge/test_merge.py

@@ -375,9 +375,9 @@ def test_merge_non_unique_indexes(self):
         dt3 = datetime(2012, 5, 3)
         dt4 = datetime(2012, 5, 4)
 
-        # df1 = DataFrame({"x": ["a"]}, index=[dt])
-        # df2 = DataFrame({"y": ["b", "c"]}, index=[dt, dt])
-        # _check_merge(df1, df2)
+        df1 = DataFrame({"x": ["a"]}, index=[dt])
+        df2 = DataFrame({"y": ["b", "c"]}, index=[dt, dt])
+        _check_merge(df1, df2)
 
         # Not monotonic
         df1 = DataFrame({"x": ["a", "b", "q"]}, index=[dt2, dt, dt4])
@@ -1480,16 +1480,13 @@ def test_merge_how_validation(self):
 def _check_merge(x, y):
     for how in ["inner", "left", "outer"]:
         for sort in [True, False]:
-            how = "inner"
-            sort = False
             result = x.join(y, how=how, sort=sort)
 
             expected = merge(x.reset_index(), y.reset_index(), how=how, sort=sort)
             expected = expected.set_index("index")
 
             # TODO check_names on merge?
             tm.assert_frame_equal(result, expected, check_names=False)
-            break
 
 
 class TestMergeDtypes: