TST: fix test class methods and lint in test_numeric.py

Author: tisjayy

pandas/tests/arithmetic/test_numeric.py

@@ -855,42 +855,30 @@ def test_modulo_zero_int(self):
             result = 0 % s
             expected = Series([np.nan, 0.0])
             tm.assert_series_equal(result, expected)
-
-    def test_np_array_mul_ea_array_returns_extensionarray():
+    
+    def test_np_array_mul_ea_array_returns_extensionarray(self):
         np_array = np.array([1, 2, 3, 4, 5], dtype=tm.SIGNED_INT_NUMPY_DTYPES[0])
         ea_array = pd.array([1, 2, 3, 4, 5], dtype=tm.SIGNED_INT_EA_DTYPES[0])
         result = np_array * ea_array
         tm.assert_isinstance(result, type(ea_array))
         tm.assert_equal(
             result, pd.array([1, 4, 9, 16, 25], dtype=tm.SIGNED_INT_EA_DTYPES[0])
         )
-        tm.assert_equal(
-            result, pd.array([1, 4, 9, 16, 25], dtype=tm.SIGNED_INT_EA_DTYPES[0])
-        )
 
-    def test_df_mul_np_and_ea_array_shape_and_errors():
+    def test_df_mul_np_and_ea_array_shape_and_errors(self):
         df = pd.DataFrame(np.arange(50).reshape(10, 5)).notna().values
-        NP_array = pd.array(
-            [i for i in range(10)], dtype=tm.SIGNED_INT_NUMPY_DTYPES[0]
-        ).reshape(10, 1)
-        EA_array = pd.array(
-            [i for i in range(10)], dtype=tm.SIGNED_INT_EA_DTYPES[0]
-        ).reshape(10, 1)
-
+        NP_array = pd.array(list(range(10)), dtype=tm.SIGNED_INT_NUMPY_DTYPES[0]).reshape(10, 1)
+        EA_array = pd.array(list(range(10)), dtype=tm.SIGNED_INT_EA_DTYPES[0]).reshape(10, 1)
         result_np = df * NP_array
         tm.assert_isinstance(result_np, np.ndarray)
         tm.assert_equal(result_np.shape, (10, 5))
 
         with tm.assert_raises(TypeError):
             _ = df * EA_array
 
-    def test_non_1d_ea_raises_typeerror():
-        ea_array = pd.array([1, 2, 3, 4, 5], dtype=tm.SIGNED_INT_EA_DTYPES[0]).reshape(
-            5, 1
-        )
-        np_array = np.array(
-            [1, 2, 3, 4, 5], dtype=tm.SIGNED_INT_NUMPY_DTYPES[0]
-        ).reshape(5, 1)
+    def test_non_1d_ea_raises_typeerror(self):
+        ea_array = pd.array([1, 2, 3, 4, 5], dtype=tm.SIGNED_INT_EA_DTYPES[0]).reshape(5, 1)
+        np_array = np.array([1, 2, 3, 4, 5], dtype=tm.SIGNED_INT_NUMPY_DTYPES[0]).reshape(5, 1)
 
         with tm.assert_raises(TypeError):
             _ = ea_array * np_array