-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
BUG: Raise TypeError for mismatched signed/unsigned dtypes in IntervalIndex.from_arrays #62376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jbrockmendel
merged 13 commits into
pandas-dev:main
from
Aniketsy:fix-intervalindex-signedness
Oct 29, 2025
Merged
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
736ae02
BUG: Raise TypeError for mismatched signed/unsigned dtypes in Interva…
Aniketsy 439efbe
BUG: Raise TypeError for mismatched signed/unsigned dtypes
Aniketsy ed887d9
BUG: Raise TypeError for mismatched signed/unsigned dtypes
Aniketsy f7433c8
BUG: Raise TypeError for mismatched signed/unsigned dtypes
Aniketsy 5b67c6e
Fix type-ignore
Aniketsy c75bec0
BUG: Raise TypeError for mismatched signed/unsigned dtypes
Aniketsy 9b6dafc
Revert "BUG: Raise TypeError for mismatched signed/unsigned dtypes"
Aniketsy 2261af1
BUG: Raise TypeError for mismatched signed/unsigned dtypes
Aniketsy 6a6b2c4
BUG: Raise TypeError for mismatched signed/unsigned dtypes
Aniketsy dd0ffb4
Merge branch 'main' into fix-intervalindex-signedness
Aniketsy 9936c81
Merge branch 'main' into fix-intervalindex-signedness
Aniketsy eb9cfa7
fix-pre-commit
Aniketsy cffb9b1
Merge branch 'main' into fix-intervalindex-signedness
Aniketsy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im confused as to why this affects from_arrays, since that goes through simple_new and not
__new__There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure but could it be as in simple_new-
IntervalMixin.__new__is called notIntervalArray.__new__.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seeing as how the added test is failing, my guess is "it doesn't". Maybe put the check at the end of _ensure_simple_new_inputs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, i'll move at the end of _ensure_simple_new_inputs.