BUGFIX: itemsize wrong for date32[day][pyarrow] dtype #57948 #62654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Fixes #57948
Summary
ArrowDtype.itemsizewas incorrectly returning8bytes fordate32[day]and otherfixed-widthPyArrow types because it always fell back tonumpy_dtype.itemsize. This PR uses PyArrow'sbit_widthforfixed-widthtypes and gracefully falls back tonumpyforvariable-widthtypes andbooleans.Changes
ArrowDtype.itemsizeto usepyarrow_dtype.bit_widthwhen availableExample
Before:
ArrowDtype(pa.date32()).itemsize == 8After:
ArrowDtype(pa.date32()).itemsize == 4