DOC: Replace @doc @appender and @substitution decorator with inline docstrings in core/window/expanding.py #62664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akashisang
changed the title
mroeschke
reviewed
Oct 13, 2025
pandas/core/window/expanding.py
Outdated
| >>> df = pd.DataFrame({"A": [1, 2, 3], "B": [4, 5, 6], "C": [7, 8, 9]}) | ||
| >>> df | ||
| A B C | ||
| A B C |
Member
There was a problem hiding this comment.
Why are these labeled dedented?
Contributor
Author
There was a problem hiding this comment.
It was an oversight. I missed it during the review.
mroeschke
reviewed
Oct 13, 2025
pandas/core/window/expanding.py
Outdated
| >>> df.ewm(alpha=0.5).mean() | ||
| A B C | ||
| A B C |
Member
There was a problem hiding this comment.
The alignment on these columns also looks off
mroeschke
reviewed
Oct 13, 2025
pandas/core/window/expanding.py
Outdated
Comment on lines
401
to
419
| >>> df = pd.DataFrame( | ||
| ... {"A": [1, 2, 3, 4]}, index=pd.date_range("2012-08-02", periods=4) | ||
| ... ) | ||
| >>> df | ||
| A | ||
| 2012-08-02 1 | ||
| 2012-08-03 2 | ||
| 2012-08-04 3 | ||
| 2012-08-05 4 | ||
| To get the difference between each expanding window's maximum and minimum | ||
| value in one pass, you can do | ||
| >>> df.expanding().pipe(lambda x: x.max() - x.min()) | ||
| A | ||
| 2012-08-02 0.0 | ||
| 2012-08-03 1.0 | ||
| 2012-08-04 2.0 | ||
| 2012-08-05 3.0 |
Contributor
Author
There was a problem hiding this comment.
I've done. and I’ve reviewed all once more, and it seems okay, maybe.
mroeschke
approved these changes
Oct 13, 2025
Member
|
Thanks @Akashisang |
mraabhijit
pushed a commit
to mraabhijit/pandas
that referenced
this pull request
Oct 17, 2025
…ocstrings in core/window/expanding.py (pandas-dev#62664)
eicchen
pushed a commit
to eicchen/pandas
that referenced
this pull request
Oct 18, 2025
…ocstrings in core/window/expanding.py (pandas-dev#62664)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Appender,@Substitution,@docwith inlined docstrings #62437doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.