Skip to content

Conversation

@Aniketsy
Copy link
Contributor

This PR updates the array_equivalent_object logic to use strict comparison (strict=True) when comparing arrays.
Please let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.
Thankyou !

@Aniketsy
Copy link
Contributor Author

Hi @jbrockmendel
After enforcing strict comparison in array_equivalent_object, I’m seeing several test failures due to the change in behavior.
should i add a deprecation warning to notify users about this stricter comparison or do i need to update the tests.

@mroeschke
Copy link
Member

Thanks for the PR, but going to close this PR awaiting more discussion in the issue

@mroeschke mroeschke closed this Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API: be stricter in array_equivalent_object

2 participants