Skip to content

TST : Removed ensure_clean from test_common_basic.py #62425 #62856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2025
Merged

TST : Removed ensure_clean from test_common_basic.py #62425 #62856

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
318c605
TST: Replace ensure_clean methods with temp_file
Jericho0912 Oct 26, 2025
9b10519
TST: replace ensure_clean with tmp_path
Jericho0912 Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 21 additions & 22 deletions pandas/tests/io/parser/common/test_common_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
from inspect import signature
from io import StringIO
import os
from pathlib import Path
import sys

import numpy as np
Expand Down Expand Up @@ -615,16 +614,16 @@ def test_sub_character(all_parsers, csv_dir_path):


@pytest.mark.parametrize("filename", ["sé-es-vé.csv", "ru-sй.csv", "中文文件名.csv"])
def test_filename_with_special_chars(all_parsers, filename):
def test_filename_with_special_chars(all_parsers, filename, tmp_path):
# see gh-15086.
parser = all_parsers
df = DataFrame({"a": [1, 2, 3]})

with tm.ensure_clean(filename) as path:
df.to_csv(path, index=False)
path = tmp_path / filename
df.to_csv(path, index=False)

result = parser.read_csv(path)
tm.assert_frame_equal(result, df)
result = parser.read_csv(path)
tm.assert_frame_equal(result, df)


def test_read_table_same_signature_as_read_csv(all_parsers):
Expand Down Expand Up @@ -786,22 +785,22 @@ def test_dict_keys_as_names(all_parsers):

@pytest.mark.xfail(using_string_dtype() and HAS_PYARROW, reason="TODO(infer_string)")
@xfail_pyarrow # UnicodeDecodeError: 'utf-8' codec can't decode byte 0xed in position 0
def test_encoding_surrogatepass(all_parsers):
def test_encoding_surrogatepass(all_parsers, tmp_path):
# GH39017
parser = all_parsers
content = b"\xed\xbd\xbf"
decoded = content.decode("utf-8", errors="surrogatepass")
expected = DataFrame({decoded: [decoded]}, index=[decoded * 2])
expected.index.name = decoded * 2

with tm.ensure_clean() as path:
Path(path).write_bytes(
content * 2 + b"," + content + b"\n" + content * 2 + b"," + content
)
df = parser.read_csv(path, encoding_errors="surrogatepass", index_col=0)
tm.assert_frame_equal(df, expected)
with pytest.raises(UnicodeDecodeError, match="'utf-8' codec can't decode byte"):
parser.read_csv(path)
path = tmp_path / "test_encoding.csv"
path.write_bytes(
content * 2 + b"," + content + b"\n" + content * 2 + b"," + content
)
df = parser.read_csv(path, encoding_errors="surrogatepass", index_col=0)
tm.assert_frame_equal(df, expected)
with pytest.raises(UnicodeDecodeError, match="'utf-8' codec can't decode byte"):
parser.read_csv(path)


def test_malformed_second_line(all_parsers):
Expand Down Expand Up @@ -835,15 +834,15 @@ def test_short_multi_line(all_parsers):
tm.assert_frame_equal(result, expected)


def test_read_seek(all_parsers):
def test_read_seek(all_parsers, tmp_path):
# GH48646
parser = all_parsers
prefix = "### DATA\n"
content = "nkey,value\ntables,rectangular\n"
with tm.ensure_clean() as path:
Path(path).write_text(prefix + content, encoding="utf-8")
with open(path, encoding="utf-8") as file:
file.readline()
actual = parser.read_csv(file)
expected = parser.read_csv(StringIO(content))
path = tmp_path / "test_seek.csv"
path.write_text(prefix + content, encoding="utf-8")
with open(path, encoding="utf-8") as file:
file.readline()
actual = parser.read_csv(file)
expected = parser.read_csv(StringIO(content))
tm.assert_frame_equal(actual, expected)
Loading