Skip to content
This repository was archived by the owner on Jun 13, 2023. It is now read-only.

Commit 910fedd

Browse files
HeEAaDflovilmart
authored andcommitted
Full Swift 4.2 compatibility (#177)
* Convert ParseLiveQuery to Swift 4.2 * Convert LiveQueryDemo/LiveQueryDemo-ObjC to Swift 4.2 * use 'public' instead of 'open' for 'let' properties * Podspec: set swift_version to 4.2 * travis-ci: add an explicit script step before the cocoapods distribution
1 parent 00ae5ab commit 910fedd

File tree

6 files changed

+17
-16
lines changed

6 files changed

+17
-16
lines changed

.travis.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ jobs:
1313
include:
1414
- stage: distribution
1515
env: CocoaPods
16+
script: bundle exec pod spec lint ParseLiveQuery.podspec --quick
1617
deploy:
1718
provider: script
1819
skip_cleanup: true

Examples/LiveQueryDemo-ObjC.xcodeproj/project.pbxproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@
244244
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks";
245245
PRODUCT_BUNDLE_IDENTIFIER = com.parse.LiveQueryDemo;
246246
PRODUCT_NAME = "$(TARGET_NAME)";
247-
SWIFT_VERSION = 3.0;
247+
SWIFT_VERSION = 4.2;
248248
};
249249
name = Debug;
250250
};
@@ -257,7 +257,7 @@
257257
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks";
258258
PRODUCT_BUNDLE_IDENTIFIER = com.parse.LiveQueryDemo;
259259
PRODUCT_NAME = "$(TARGET_NAME)";
260-
SWIFT_VERSION = 3.0;
260+
SWIFT_VERSION = 4.2;
261261
};
262262
name = Release;
263263
};

Examples/LiveQueryDemo.xcodeproj/project.pbxproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@
146146
TargetAttributes = {
147147
F509D5161CA9E4AE007B15B0 = {
148148
CreatedOnToolsVersion = 7.3;
149-
LastSwiftMigration = 0800;
149+
LastSwiftMigration = 1010;
150150
};
151151
};
152152
};
@@ -225,7 +225,7 @@
225225
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks";
226226
PRODUCT_BUNDLE_IDENTIFIER = com.parse.LiveQueryDemo;
227227
PRODUCT_NAME = "$(TARGET_NAME)";
228-
SWIFT_VERSION = 3.0;
228+
SWIFT_VERSION = 4.2;
229229
};
230230
name = Debug;
231231
};
@@ -239,7 +239,7 @@
239239
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks";
240240
PRODUCT_BUNDLE_IDENTIFIER = com.parse.LiveQueryDemo;
241241
PRODUCT_NAME = "$(TARGET_NAME)";
242-
SWIFT_VERSION = 3.0;
242+
SWIFT_VERSION = 4.2;
243243
};
244244
name = Release;
245245
};

ParseLiveQuery.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Pod::Spec.new do |s|
1212
s.requires_arc = true
1313

1414
s.platform = :ios, :osx, :tvos
15-
s.swift_version = '3.2'
15+
s.swift_version = '4.2'
1616
s.cocoapods_version = '>= 1.4'
1717

1818
s.ios.deployment_target = '8.0'

Sources/ParseLiveQuery.xcodeproj/project.pbxproj

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -489,10 +489,10 @@
489489
TargetAttributes = {
490490
F5903CE91BD999C500C3EFFE = {
491491
CreatedOnToolsVersion = 7.1;
492-
LastSwiftMigration = 0920;
492+
LastSwiftMigration = 1010;
493493
};
494494
F5A9BFB61BE0248D00E78326 = {
495-
LastSwiftMigration = 0920;
495+
LastSwiftMigration = 1010;
496496
};
497497
};
498498
};
@@ -788,7 +788,7 @@
788788
MACOSX_DEPLOYMENT_TARGET = 10.10;
789789
ONLY_ACTIVE_ARCH = YES;
790790
SWIFT_OBJC_BRIDGING_HEADER = "";
791-
SWIFT_VERSION = 4.0;
791+
SWIFT_VERSION = 4.2;
792792
};
793793
name = Debug;
794794
};
@@ -823,7 +823,7 @@
823823
MACOSX_DEPLOYMENT_TARGET = 10.10;
824824
SWIFT_OBJC_BRIDGING_HEADER = "";
825825
SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";
826-
SWIFT_VERSION = 4.0;
826+
SWIFT_VERSION = 4.2;
827827
};
828828
name = Release;
829829
};
@@ -848,7 +848,7 @@
848848
SDKROOT = macosx;
849849
SKIP_INSTALL = YES;
850850
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
851-
SWIFT_VERSION = 4.0;
851+
SWIFT_VERSION = 4.2;
852852
};
853853
name = Debug;
854854
};
@@ -872,7 +872,7 @@
872872
PRODUCT_NAME = ParseLiveQuery;
873873
SDKROOT = macosx;
874874
SKIP_INSTALL = YES;
875-
SWIFT_VERSION = 4.0;
875+
SWIFT_VERSION = 4.2;
876876
};
877877
name = Release;
878878
};
@@ -898,7 +898,7 @@
898898
SKIP_INSTALL = YES;
899899
SWIFT_INSTALL_OBJC_HEADER = YES;
900900
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
901-
SWIFT_VERSION = 4.0;
901+
SWIFT_VERSION = 4.2;
902902
TARGETED_DEVICE_FAMILY = "1,2";
903903
};
904904
name = Debug;
@@ -924,7 +924,7 @@
924924
SDKROOT = iphoneos;
925925
SKIP_INSTALL = YES;
926926
SWIFT_INSTALL_OBJC_HEADER = YES;
927-
SWIFT_VERSION = 4.0;
927+
SWIFT_VERSION = 4.2;
928928
TARGETED_DEVICE_FAMILY = "1,2";
929929
};
930930
name = Release;

Sources/ParseLiveQuery/ObjCCompat.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,11 @@ public struct ObjCCompat {
9797
open class Event: NSObject {
9898
/// Type of the event.
9999
@objc
100-
open let type: PFLiveQueryEventType
100+
public let type: PFLiveQueryEventType
101101

102102
/// Object this event is for.
103103
@objc
104-
open let object: PFObject
104+
public let object: PFObject
105105

106106
init(type: PFLiveQueryEventType, object: PFObject) {
107107
self.type = type

0 commit comments

Comments
 (0)