Skip to content

Conversation

@anandijain
Copy link
Collaborator

now we can

julia>     @named sys = sbml2odesystem(fn) 
Model sys with 2 equations   <-- `sys`
States (2):
  S1(t) [defaults to 0.00015]
  S2(t) [defaults to 0.0]
Parameters (2):
  k1 [defaults to 1.0]
  compartment [defaults to 1.0]

Also the sort on the tests is weird, but I don't think that the prob.p is deterministic. We can easily revert back once that's figured out, in the meantime better to test than not at all.

@anandijain anandijain requested a review from paulflang March 5, 2021 21:16
@paulflang
Copy link
Owner

Thanks for making these changes, here are my comments:

  • adding kwargs seems good.
  • Wondering if you leave away the variable definition in test/sbml2modelingtoolkit.jl line 19 (@variables A(t) B(t)). It is probably good to get an error in line 21 when getinitialconditions(model) does not create them.

One thing though: In case you forgot to merge into develop and directly merged into main, develop will be left behind. To make sure develop is never behind main, please immediately merge main into develop. We don’t wont anybody to create their own feature branch from an outdated develop.

@anandijain
Copy link
Collaborator Author

That's a good point, there is probably a better way to avoid namespace stuff.
I added it to get rid of one of the repr tests that was causing me trouble. I was getting

sbml2modelingtoolkit.jl: Test Failed at /home/runner/work/SbmlInterface.jl/SbmlInterface.jl/test/sbml2modelingtoolkit.jl:31
  Expression: repr(ModelingToolkit.get_states(odesys)) == "Term{Real}[A(t), B(t)]"
   Evaluated: "Term{Real, Nothing}[A(t), B(t)]" == "Term{Real}[A(t), B(t)]"

here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants