Implement

Author: SOHELAHMED7

README.md

@@ -350,7 +350,7 @@ related objects, `x-no-relation` (type: boolean, default: false) is used.
 
 This will not generate 'comments' column in database migrations. But it will generate `getComments()` relation in Yii model file.
 
-In order to make it real database column, extension `x-no-relation` can be used.
+In order to make it real database column, OpenAPI extension `x-no-relation` can be used.
 
 ```yaml
         comments:

src/lib/AttributeResolver.php

@@ -278,7 +278,9 @@ protected function resolveProperty(
             if ($property->isRefPointerToSelf()) {
                 $relation->asSelfReference();
             }
-            $this->relations[$property->getName()] = $relation;
+            if (empty($property->getAttr(CustomSpecAttr::NO_RELATION))) {
+                $this->relations[$property->getName()] = $relation;
+            }
             if (!$property->isRefPointerToSelf()) {
                 $this->addInverseRelation($relatedClassName, $attribute, $property, $fkProperty);
             }
@@ -321,21 +323,25 @@ protected function resolveProperty(
                         $fkProperty->getName(),
                         '_id'
                     )) {
+                    if (empty($property->getAttr(CustomSpecAttr::NO_RELATION))) {
+                        $this->relations[$property->getName()] =
+                            Yii::createObject(
+                                AttributeRelation::class,
+                                [static::relationName($property->getName(), $property->fkColName), $relatedTableName, $relatedClassName]
+                            )
+                                ->asHasMany([$fkProperty->getName() => $fkProperty->getName()])->asSelfReference();
+                    }
+                    return;
+                }
+                $foreignPk = Inflector::camel2id($fkProperty->getName(), '_') . '_id';
+                if (empty($property->getAttr(CustomSpecAttr::NO_RELATION))) {
                     $this->relations[$property->getName()] =
                         Yii::createObject(
                             AttributeRelation::class,
                             [static::relationName($property->getName(), $property->fkColName), $relatedTableName, $relatedClassName]
                         )
-                            ->asHasMany([$fkProperty->getName() => $fkProperty->getName()])->asSelfReference();
-                    return;
+                            ->asHasMany([$foreignPk => $this->componentSchema->getPkName()]);
                 }
-                $foreignPk = Inflector::camel2id($fkProperty->getName(), '_') . '_id';
-                $this->relations[$property->getName()] =
-                    Yii::createObject(
-                        AttributeRelation::class,
-                        [static::relationName($property->getName(), $property->fkColName), $relatedTableName, $relatedClassName]
-                    )
-                        ->asHasMany([$foreignPk => $this->componentSchema->getPkName()]);
                 return;
             }
             $relatedClassName = $property->getRefClassName();
@@ -349,13 +355,15 @@ protected function resolveProperty(
                 return;
             }
             $attribute->setPhpType($relatedClassName . '[]');
-            $this->relations[$property->getName()] =
-                Yii::createObject(
-                    AttributeRelation::class,
-                    [static::relationName($property->getName(), $property->fkColName), $relatedTableName, $relatedClassName]
-                )
-                    ->asHasMany([Inflector::camel2id($this->schemaName, '_') . '_id' => $this->componentSchema->getPkName()])
-                    ->setInverse(Inflector::variablize($this->schemaName));
+            if (empty($property->getAttr(CustomSpecAttr::NO_RELATION))) {
+                $this->relations[$property->getName()] =
+                    Yii::createObject(
+                        AttributeRelation::class,
+                        [static::relationName($property->getName(), $property->fkColName), $relatedTableName, $relatedClassName]
+                    )
+                        ->asHasMany([Inflector::camel2id($this->schemaName, '_') . '_id' => $this->componentSchema->getPkName()])
+                        ->setInverse(Inflector::variablize($this->schemaName));
+            }
             return;
         }
         if ($this->componentSchema->isNonDb() && $attribute->isReference()) {

tests/specs/issue_fix/20_consider_openapi_spec_examples_in_faker_code_generation/mysql/models/base/Pet.php

@@ -29,7 +29,6 @@
  * @property array $one_of_from_multi_ref_arr
  *
  * @property array|\app\models\User[] $userRefObjArrNormal
- * @property array|\app\models\User[] $userRefObjArr
  */
 abstract class Pet extends \yii\db\ActiveRecord
 {
@@ -53,9 +52,4 @@ public function getUserRefObjArrNormal()
     {
         return $this->hasMany(\app\models\User::class, ['pet_id' => 'id'])->inverseOf('pet');
     }
-
-    public function getUserRefObjArr()
-    {
-        return $this->hasMany(\app\models\User::class, ['pet_id' => 'id'])->inverseOf('pet');
-    }
 }

tests/specs/issue_fix/23_consider_openapi_extension_x_no_relation_also_in_other_pertinent_place/index.php

@@ -0,0 +1,13 @@
+<?php
+
+return [
+    'openApiPath' => '@specs/issue_fix/23_consider_openapi_extension_x_no_relation_also_in_other_pertinent_place/index.yaml',
+    'generateUrls' => false,
+    'generateModels' => true,
+    'excludeModels' => [
+        'Error',
+    ],
+    'generateControllers' => false,
+    'generateMigrations' => true,
+    'generateModelFaker' => true, // `generateModels` must be `true` in order to use `generateModelFaker` as `true`
+];

tests/specs/issue_fix/23_consider_openapi_extension_x_no_relation_also_in_other_pertinent_place/index.yaml

@@ -0,0 +1,35 @@
+openapi: 3.0.3
+
+info:
+  title: '#23'
+  version: 1.0.0
+
+paths:
+  /:
+    get:
+      responses:
+        '200':
+          description: The Response
+
+
+
+components:
+  schemas:
+    Payments:
+      properties:
+        id:
+          type: integer
+        currency:
+          type: string
+        samples:
+          type: array
+          x-no-relation: true
+          items:
+            $ref: '#/components/schemas/Sample'
+
+    Sample:
+      properties:
+        id:
+          type: integer
+        message:
+          type: string

tests/unit/IssueFixTest.php

@@ -1001,4 +1001,20 @@ public function test74InvalidSchemaReferenceError()
         $this->runActualMigrations();
     }
 
+    // https://github.com/php-openapi/yii2-openapi/issues/23
+    public function test23ConsiderOpenapiExtensionXNoRelationAlsoInOtherPertinentPlace()
+    {
+//        23-consider-openapi-extension-x-no-relation-also-in-other-pertinent-place
+//        23_consider_openapi_extension_x_no_relation_also_in_other_pertinent_place
+        $testFile = Yii::getAlias("@specs/issue_fix/23_consider_openapi_extension_x_no_relation_also_in_other_pertinent_place/index.php");
+        $this->runGenerator($testFile);
+//        $actualFiles = FileHelper::findFiles(Yii::getAlias('@app'), [
+//            'recursive' => true,
+//        ]);
+//        $expectedFiles = FileHelper::findFiles(Yii::getAlias("@specs/issue_fix/23_consider_openapi_extension_x_no_relation_also_in_other_pertinent_place/mysql"), [
+//            'recursive' => true,
+//        ]);
+//        $this->checkFiles($actualFiles, $expectedFiles);
+//        $this->runActualMigrations();
+    }
 }