Refactor and fix failing test

Author: SOHELAHMED7

src/lib/generators/ControllersGenerator.php

@@ -126,11 +126,19 @@ protected function makeCustomController(
         ];
         $reflection->addMethod('checkAccess', $params, AbstractMemberGenerator::FLAG_PUBLIC, '//TODO implement checkAccess');
         foreach ($abstractActions as $action) {
-
             $responseHttpStatusCodes = '';
             foreach ($this->config->getOpenApi()->paths->getPaths()[$action->urlPath]->getOperations() as $verb => $operation) {
                 $codes = array_keys($operation->responses->getResponses());
-                if ($verb === strtolower($action->requestMethod) && $codes !== [200]) {
+
+                $only200OrDefault = false;
+                if ($codes === [200] || $codes === ['default']) {
+                    $only200OrDefault = true;
+                }
+                if (in_array('default', $codes) && in_array(200, $codes) && count($codes) === 2) {
+                    $only200OrDefault = true;
+                }
+
+                if ($verb === strtolower($action->requestMethod) && !$only200OrDefault) {
                     $responseHttpStatusCodes = implode(', ', $codes);
                 }
             }

tests/specs/blog_v2/controllers/CommentController.php

@@ -18,6 +18,7 @@ public function actionListForPost($postId)
     public function actionCreateForPost($postId)
     {
         //TODO implement actionCreateForPost
+        // In order to conform with OpenAPI spec, response of this action must have one of the following HTTP status code: 201, default
     }
 
     public function actionViewForPost($slug, $id)
@@ -28,6 +29,7 @@ public function actionViewForPost($slug, $id)
     public function actionDeleteForPost($slug, $id)
     {
         //TODO implement actionDeleteForPost
+        // In order to conform with OpenAPI spec, response of this action must have one of the following HTTP status code: 204
     }
 
     public function actionUpdateForPost($slug, $id)

tests/specs/issue_fix/163_generator_crash_when_using_reference_inside_an_object/pgsql/controllers/ContactController.php

@@ -13,11 +13,13 @@ public function checkAccess($action, $model = null, $params = [])
     public function actionListForAccount($accountId)
     {
         //TODO implement actionListForAccount
+        // In order to conform with OpenAPI spec, response of this action must have one of the following HTTP status code: 200, 403
     }
 
     public function actionViewForAccount($accountId, $contactId)
     {
         //TODO implement actionViewForAccount
+        // In order to conform with OpenAPI spec, response of this action must have one of the following HTTP status code: 200, 403
     }
 
 

tests/specs/issue_fix/175_bug_allof_with_multiple_dollarrefs/pgsql/controllers/AccountController.php

@@ -13,6 +13,7 @@ public function checkAccess($action, $model = null, $params = [])
     public function actionView($id)
     {
         //TODO implement actionView
+        // In order to conform with OpenAPI spec, response of this action must have one of the following HTTP status code: 200, 404
     }
 
 

tests/specs/issue_fix/79_response_status_codes_are_not_the_codes_defined_in_spec/mysql/controllers/MangoController.php

@@ -12,13 +12,13 @@ public function checkAccess($action, $model = null, $params = [])
 
     public function actionCake()
     {
-        // TODO implement actionCake
+        //TODO implement actionCake
         // In order to conform with OpenAPI spec, response of this action must have one of the following HTTP status code: 200, 403, 404
     }
 
     public function actionCreateCake()
     {
-        // TODO implement actionCreateCake
+        //TODO implement actionCreateCake
         // In order to conform with OpenAPI spec, response of this action must have one of the following HTTP status code: 201, 403, 404, 422
     }