Add phpstan-strict-rules

Author: steevanb

.circleci/config.yml

@@ -10,13 +10,11 @@ jobs:
             - restore_cache:
                 key: vendor-{{ checksum "composer.json" }}-{{ checksum "composer.lock" }}
             - run:
-                composer install --ignore-platform-reqs --no-interaction
+                name: Install Composer dependencies
+                command:
+                    composer install --ignore-platform-reqs --no-interaction
             - save_cache:
                 key: vendor-{{ checksum "composer.json" }}-{{ checksum "composer.lock" }}
-                paths:
-                    - ./vendor
-            - persist_to_workspace:
-                root: .
                 paths:
                     - vendor
 

composer.json

@@ -33,6 +33,7 @@
     },
     "require-dev": {
         "phpstan/phpstan": "0.12.*",
+        "phpstan/phpstan-strict-rules": "^0.12.2",
         "phpstan/phpstan-symfony": "0.12.*",
         "steevanb/php-backtrace": "2.0.*",
         "symfony/var-dumper": "4.4.*"

composer.lock

@@ -7,5 +7,8 @@ parameters:
         container_xml_path: /app/var/cache/dev/srcApp_KernelDevDebugContainer.xml
     excludes_analyse:
         - src/Version.php
+    ignoreErrors:
+        - '#Variable static method call on App\\Benchmark\\Benchmark.#'
 includes:
     - /app/vendor/phpstan/phpstan-symfony/extension.neon
+    - /app/vendor/phpstan/phpstan-strict-rules/rules.neon

phpstan.neon

@@ -271,7 +271,7 @@ protected function doRunProcess(
         string $silencedError = null
     ): self {
         $processResult = $process->run(
-            function (string $type, string $line) use ($outputVerbosity) {
+            function (string $type, string $line) use ($outputVerbosity): void {
                 if ($this->getOutput()->getVerbosity() >= $outputVerbosity) {
                     $this->getOutput()->writeln($line);
                 }

src/Command/AbstractCommand.php

@@ -181,7 +181,7 @@ private function getCoreDependency(string $componentSlug): array
 
                 $name = $this->getInput()->getOption('core-dependency-name');
                 if (is_string($name) === true) {
-                    if (in_array($name, $choices) === false) {
+                    if (in_array($name, $choices, true) === false) {
                         throw new \Exception("Core dependency name $name not found in composer.json.");
                     }
                 } else {

src/Command/Configure/ConfigurePhpBenchmarksCommand.php

@@ -34,7 +34,7 @@ protected function afterHttpCodeValidated(
         PhpVersion $phpVersion,
         BenchmarkConfiguration $benchmarkConfiguration,
         ?string $body
-    ): self {
+    ): parent {
         if (is_string($body) === false || strlen($body) === 0) {
             throw new \Exception('phpinfo() should not output an empty string.');
         }

src/Command/Validate/Benchmark/ValidateBenchmarkPhpInfoCommand.php

@@ -37,7 +37,7 @@ protected function afterHttpCodeValidated(
         PhpVersion $phpVersion,
         BenchmarkConfiguration $benchmarkConfiguration,
         ?string $body
-    ): self {
+    ): parent {
         $validated = false;
         $responseBodyPath = Path::getResponseBodyPath($phpVersion);
 

src/Command/Validate/Benchmark/ValidateBenchmarkResponseCommand.php

@@ -40,7 +40,7 @@ protected function afterHttpCodeValidated(
         PhpVersion $phpVersion,
         BenchmarkConfiguration $benchmarkConfiguration,
         ?string $body
-    ): self {
+    ): parent {
         // Wait for statistics.json file to be written, sometimes it's not the case at this stage
         sleep(1);
 

src/Command/Validate/Benchmark/ValidateBenchmarkStatisticsCommand.php

@@ -71,7 +71,7 @@ private function assertCodeSourceUrls(): self
 
         $urls = Benchmark::getSourceCodeUrls();
         foreach ($urls as $id => $url) {
-            if (in_array($id, $expectedUrlIds) === false) {
+            if (in_array($id, $expectedUrlIds, true) === false) {
                 throw new \Exception('Configuration sourceCode.urls contains an unknown key "' . $id . '".');
             }