Skip to content

Commit d1bbefe

Browse files
committed
PHP 7.3
1 parent 6981d8e commit d1bbefe

File tree

8 files changed

+2687
-247
lines changed

8 files changed

+2687
-247
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,4 @@
1010
/bin/
1111
/.idea/
1212
composer.lock
13+
/var/

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
You will find lot of benchmarks for PHP frameworks and template engines.
1010

11-
You can compare results between Apache Bench and Siege, and PHP 5.6 to 7.2.
11+
You can compare results between Apache Bench and Siege, and PHP 5.6 to 7.3.
1212

1313
## What is this repository ?
1414

app/SymfonyRequirements.php

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ public function __construct()
389389
{
390390
/* mandatory requirements follow */
391391

392-
$installedPhpVersion = phpversion();
392+
$installedPhpVersion = PHP_VERSION;
393393
$requiredPhpVersion = $this->getPhpRequiredVersion();
394394

395395
$this->addRecommendation(
@@ -446,15 +446,8 @@ public function __construct()
446446
);
447447

448448
if (false !== $requiredPhpVersion && version_compare($installedPhpVersion, $requiredPhpVersion, '>=')) {
449-
$timezones = array();
450-
foreach (DateTimeZone::listAbbreviations() as $abbreviations) {
451-
foreach ($abbreviations as $abbreviation) {
452-
$timezones[$abbreviation['timezone_id']] = true;
453-
}
454-
}
455-
456449
$this->addRequirement(
457-
isset($timezones[@date_default_timezone_get()]),
450+
in_array(@date_default_timezone_get(), DateTimeZone::listIdentifiers(), true),
458451
sprintf('Configured default timezone "%s" must be supported by your installation of PHP', @date_default_timezone_get()),
459452
'Your default timezone is not supported by PHP. Check for typos in your <strong>php.ini</strong> file and have a look at the list of deprecated timezones at <a href="http://php.net/manual/en/timezones.others.php">http://php.net/manual/en/timezones.others.php</a>.'
460453
);
@@ -720,7 +713,7 @@ function_exists('posix_isatty'),
720713
'Install and/or enable a <strong>PHP accelerator</strong> (highly recommended).'
721714
);
722715

723-
if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
716+
if ('WIN' === strtoupper(substr(PHP_OS, 0, 3))) {
724717
$this->addRecommendation(
725718
$this->getRealpathCacheSize() >= 5 * 1024 * 1024,
726719
'realpath_cache_size should be at least 5M in php.ini',

0 commit comments

Comments
 (0)