Regression test

Closes #383

Author: ondrejmirtes

tests/Rules/DeadCode/UnusedPrivatePropertyRuleTest.php

@@ -19,7 +19,10 @@ protected function getRule(): Rule
 
 	public static function getAdditionalConfigFiles(): array
 	{
-		return [__DIR__ . '/../../../extension.neon'];
+		return [
+			__DIR__ . '/../../../extension.neon',
+			__DIR__ . '/entity-manager.neon',
+		];
 	}
 
 	public function testRule(): void
@@ -47,4 +50,29 @@ public function testRule(): void
 		]);
 	}
 
+	public function testBug383(): void
+	{
+		if (PHP_VERSION_ID < 80100) {
+			self::markTestSkipped('Test requires PHP 8.1.');
+		}
+
+		$this->analyse([__DIR__ . '/data/bug-383.php'], [
+			[
+				'Property PHPStan\Rules\Doctrine\ORMAttributes\Bug383\Campus::$id is never written, only read.',
+				13,
+				'See: https://phpstan.org/developing-extensions/always-read-written-properties',
+			],
+			[
+				'Property PHPStan\Rules\Doctrine\ORMAttributes\Bug383\Campus::$students is never written, only read.',
+				19,
+				'See: https://phpstan.org/developing-extensions/always-read-written-properties',
+			],
+			[
+				'Property PHPStan\Rules\Doctrine\ORMAttributes\Bug383\Student::$campus is unused.',
+				29,
+				'See: https://phpstan.org/developing-extensions/always-read-written-properties',
+			],
+		]);
+	}
+
 }

tests/Rules/DeadCode/data/bug-383.php

@@ -0,0 +1,31 @@
+<?php
+
+namespace PHPStan\Rules\Doctrine\ORMAttributes\Bug383;
+
+use Doctrine\ORM\Mapping as ORM;
+use Doctrine\Common\Collections\Collection;
+
+#[ORM\Entity]
+class Campus {
+
+	#[ORM\Column(type: 'int')]
+	#[ORM\Id]
+	private int $id;
+
+	/**
+	 * @var Collection<int, Student>
+	 */
+	#[ORM\OneToMany(mappedBy: 'campus', targetEntity: Student::class)]
+	private Collection $students;
+
+	// .......
+}
+
+#[ORM\Entity]
+class Student {
+	// ......
+	#[ORM\ManyToOne(targetEntity: Campus::class, inversedBy: 'students')]
+	#[ORM\JoinColumn(nullable: false)]
+	private Campus $campus;
+	// .......
+}

tests/Rules/DeadCode/entity-manager.neon

@@ -0,0 +1,3 @@
+parameters:
+	doctrine:
+		objectManagerLoader: entity-manager.php

tests/Rules/DeadCode/entity-manager.php

@@ -0,0 +1,31 @@
+<?php declare(strict_types = 1);
+
+use Doctrine\ORM\Configuration;
+use Doctrine\ORM\EntityManager;
+use Doctrine\ORM\Mapping\Driver\AttributeDriver;
+use Doctrine\Persistence\Mapping\Driver\MappingDriverChain;
+use Symfony\Component\Cache\Adapter\ArrayAdapter;
+use Symfony\Component\Cache\DoctrineProvider;
+
+$config = new Configuration();
+$config->setProxyDir(__DIR__);
+$config->setProxyNamespace('PHPstan\Doctrine\OrmProxies');
+$config->setMetadataCacheImpl(new DoctrineProvider(new ArrayAdapter()));
+
+$metadataDriver = new MappingDriverChain();
+if (PHP_VERSION_ID >= 80100) {
+	$metadataDriver->addDriver(
+		new AttributeDriver([__DIR__ . '/data']),
+		'PHPStan\\Rules\\Doctrine\\ORMAttributes\\'
+	);
+}
+
+$config->setMetadataDriverImpl($metadataDriver);
+
+return EntityManager::create(
+	[
+		'driver' => 'pdo_sqlite',
+		'memory' => true,
+	],
+	$config
+);