Make rules.neon safe to use by everyone

Author: ondrejmirtes

composer.json

@@ -11,7 +11,8 @@
 		},
 		"phpstan": {
 			"includes": [
-				"extension.neon"
+				"extension.neon",
+				"rules.neon"
 			]
 		}
 	},

src/Rules/Doctrine/ORM/DqlRule.php

@@ -5,7 +5,6 @@
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
-use PHPStan\ShouldNotHappenException;
 use PHPStan\Type\Doctrine\ObjectMetadataResolver;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\TypeUtils;
@@ -59,7 +58,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$objectManager = $this->objectMetadataResolver->getObjectManager();
 		if ($objectManager === null) {
-			throw new ShouldNotHappenException('Please provide the "objectManagerLoader" setting for the DQL validation.');
+			return [];
 		}
 		if (!$objectManager instanceof $entityManagerInterface) {
 			return [];

src/Rules/Doctrine/ORM/MagicRepositoryMethodCallRule.php

@@ -78,11 +78,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$objectManager = $this->objectMetadataResolver->getObjectManager();
 		if ($objectManager === null) {
-			throw new \PHPStan\ShouldNotHappenException(sprintf(
-				'Please provide the "objectManagerLoader" setting for magic repository %s::%s() method validation.',
-				$calledOnType->getClassName(),
-				$methodName
-			));
+			return [];
 		}
 
 		$fieldName = $this->classify($methodFieldName);

src/Rules/Doctrine/ORM/QueryBuilderDqlRule.php

@@ -6,7 +6,6 @@
 use PhpParser\Node\Expr\MethodCall;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
-use PHPStan\ShouldNotHappenException;
 use PHPStan\Type\Doctrine\DoctrineTypeUtils;
 use PHPStan\Type\Doctrine\ObjectMetadataResolver;
 use PHPStan\Type\ObjectType;
@@ -82,7 +81,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$objectManager = $this->objectMetadataResolver->getObjectManager();
 		if ($objectManager === null) {
-			throw new ShouldNotHappenException('Please provide the "objectManagerLoader" setting for the DQL validation.');
+			return [];
 		}
 
 		$entityManagerInterface = 'Doctrine\ORM\EntityManagerInterface';

src/Rules/Doctrine/ORM/RepositoryMethodCallRule.php

@@ -65,11 +65,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		$objectManager = $this->objectMetadataResolver->getObjectManager();
 		if ($objectManager === null) {
-			throw new \PHPStan\ShouldNotHappenException(sprintf(
-				'Please provide the "objectManagerLoader" setting for magic repository %s::%s() method validation.',
-				$calledOnType->getClassName(),
-				$methodName
-			));
+			return [];
 		}
 
 		$entityClass = $calledOnType->getEntityClass();