Decimal & Float: separate the fix to separate PR

janedbal · janedbal · commit b235cea16c31 · 2024-06-25T12:20:13.000+02:00
diff --git a/src/Type/Doctrine/Descriptors/DecimalType.php b/src/Type/Doctrine/Descriptors/DecimalType.php
@@ -41,14 +41,7 @@ public function getWritableToDatabaseType(): Type
 
 	public function getDatabaseInternalType(): Type
 	{
-		return TypeCombinator::union(
-			new FloatType(),
-			new IntegerType(),
-			new IntersectionType([
-				new StringType(),
-				new AccessoryNumericStringType(),
-			])
-		);
+		return TypeCombinator::union(new FloatType(), new IntegerType());
 	}
 
 	public function getDatabaseInternalTypeForDriver(Connection $connection): Type
diff --git a/src/Type/Doctrine/Descriptors/FloatType.php b/src/Type/Doctrine/Descriptors/FloatType.php
@@ -40,13 +40,7 @@ public function getWritableToDatabaseType(): Type
 
 	public function getDatabaseInternalType(): Type
 	{
-		return TypeCombinator::union(
-			new \PHPStan\Type\FloatType(),
-			new IntersectionType([
-				new StringType(),
-				new AccessoryNumericStringType(),
-			])
-		);
+		return TypeCombinator::union(new \PHPStan\Type\FloatType(), new IntegerType());
 	}
 
 	public function getDatabaseInternalTypeForDriver(Connection $connection): Type

Original file line number	Diff line number	Diff line change
`@@ -41,14 +41,7 @@ public function getWritableToDatabaseType(): Type`
`41`	`41`
`42`	`42`	`public function getDatabaseInternalType(): Type`
`43`	`43`	`{`
`44`		`- return TypeCombinator::union(`
`45`		`- new FloatType(),`
`46`		`- new IntegerType(),`
`47`		`- new IntersectionType([`
`48`		`- new StringType(),`
`49`		`- new AccessoryNumericStringType(),`
`50`		`- ])`
`51`		`- );`
	`44`	`+ return TypeCombinator::union(new FloatType(), new IntegerType());`
`52`	`45`	`}`
`53`	`46`
`54`	`47`	`public function getDatabaseInternalTypeForDriver(Connection $connection): Type`
Original file line number	Diff line number	Diff line change
`@@ -40,13 +40,7 @@ public function getWritableToDatabaseType(): Type`
`40`	`40`
`41`	`41`	`public function getDatabaseInternalType(): Type`
`42`	`42`	`{`
`43`		`- return TypeCombinator::union(`
`44`		`- new \PHPStan\Type\FloatType(),`
`45`		`- new IntersectionType([`
`46`		`- new StringType(),`
`47`		`- new AccessoryNumericStringType(),`
`48`		`- ])`
`49`		`- );`
	`43`	`+ return TypeCombinator::union(new \PHPStan\Type\FloatType(), new IntegerType());`
`50`	`44`	`}`
`51`	`45`
`52`	`46`	`public function getDatabaseInternalTypeForDriver(Connection $connection): Type`