Added tests for OneToOne relations

Author: lookyman

tests/Rules/Doctrine/ORM/EntityRelationRuleTest.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Rules\Doctrine\ORM;
 
+use Iterator;
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
 use PHPStan\Type\Doctrine\ObjectMetadataResolver;
@@ -16,9 +17,35 @@ protected function getRule(): Rule
 		);
 	}
 
-	public function testRule(): void
+	/**
+	 * @dataProvider ruleProvider
+	 */
+	public function testRule(string $file, array $expectedErrors): void
 	{
-		$this->analyse([__DIR__ . '/data/EntityWithRelations.php'], []);
+		$this->analyse([$file], $expectedErrors);
+	}
+
+	public function ruleProvider(): Iterator
+	{
+		yield [__DIR__ . '/data/EntityWithRelations.php', []];
+		yield [__DIR__ . '/data/EntityWithBrokenOneToOneRelations.php', [
+			[
+				'Property can contain PHPStan\Rules\Doctrine\ORM\AnotherEntity|null but database expects PHPStan\Rules\Doctrine\ORM\AnotherEntity.',
+				31,
+			],
+			[
+				'Database can contain PHPStan\Rules\Doctrine\ORM\AnotherEntity|null but property expects PHPStan\Rules\Doctrine\ORM\AnotherEntity.',
+				37,
+			],
+			[
+				'Database can contain PHPStan\Rules\Doctrine\ORM\AnotherEntity|null but property expects PHPStan\Rules\Doctrine\ORM\MyEntity|null.',
+				50,
+			],
+			[
+				'Property can contain PHPStan\Rules\Doctrine\ORM\MyEntity|null but database expects PHPStan\Rules\Doctrine\ORM\AnotherEntity|null.',
+				50,
+			]
+		]];
 	}
 
 }

tests/Rules/Doctrine/ORM/data/EntityWithBrokenOneToOneRelations.php

@@ -0,0 +1,52 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Doctrine\ORM;
+
+use Doctrine\ORM\Mapping as ORM;
+
+/**
+ * @ORM\Entity()
+ */
+class EntityWithBrokenOneToOneRelations
+{
+
+	/**
+	 * @ORM\Id()
+	 * @ORM\Column(type="int")
+	 * @var int
+	 */
+	private $id;
+
+	/**
+	 * @ORM\OneToOne(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity")
+	 * @var \PHPStan\Rules\Doctrine\ORM\AnotherEntity|null
+	 */
+	private $oneToOneNullableBoth;
+
+	/**
+	 * @ORM\OneToOne(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity")
+	 * @ORM\JoinColumn(nullable=false)
+	 * @var \PHPStan\Rules\Doctrine\ORM\AnotherEntity|null
+	 */
+	private $oneToOneNullableProperty;
+
+	/**
+	 * @ORM\OneToOne(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity")
+	 * @var \PHPStan\Rules\Doctrine\ORM\AnotherEntity
+	 */
+	private $oneToOneNullableColumn;
+
+	/**
+	 * @ORM\OneToOne(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity")
+	 * @ORM\JoinColumn(nullable=false)
+	 * @var \PHPStan\Rules\Doctrine\ORM\AnotherEntity
+	 */
+	private $oneToOneNonNullable;
+
+	/**
+	 * @ORM\OneToOne(targetEntity="PHPStan\Rules\Doctrine\ORM\AnotherEntity")
+	 * @var \PHPStan\Rules\Doctrine\ORM\MyEntity|null
+	 */
+	private $oneToOneWrongClass;
+
+}