Fix build

Author: ondrejmirtes

src/Reflection/Doctrine/EntityRepositoryClassReflectionExtension.php

@@ -65,8 +65,13 @@ public function hasMethod(\PHPStan\Reflection\ClassReflection $classReflection,
 			return false;
 		}
 
+		$classReflection = $entityClassType->getClassReflection();
+		if ($classReflection === null) {
+			return false;
+		}
+
 		$fieldName = $this->classify($methodFieldName);
-		$classMetadata = $objectManager->getClassMetadata($entityClassType->getClassName());
+		$classMetadata = $objectManager->getClassMetadata($classReflection->getName());
 
 		return $classMetadata->hasField($fieldName) || $classMetadata->hasAssociation($fieldName);
 	}

src/Rules/Doctrine/ORM/EntityNotFinalRule.php

@@ -4,12 +4,13 @@
 
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
+use PHPStan\Node\InClassNode;
 use PHPStan\Rules\Rule;
 use PHPStan\Type\Doctrine\ObjectMetadataResolver;
 use function sprintf;
 
 /**
- * @implements Rule<Node\Stmt\Class_>
+ * @implements Rule<InClassNode>
  */
 class EntityNotFinalRule implements Rule
 {
@@ -24,12 +25,16 @@ public function __construct(ObjectMetadataResolver $objectMetadataResolver)
 
 	public function getNodeType(): string
 	{
-		return Node\Stmt\Class_::class;
+		return InClassNode::class;
 	}
 
 	public function processNode(Node $node, Scope $scope): array
 	{
-		if (! $node->isFinal()) {
+		$classReflection = $scope->getClassReflection();
+		if ($classReflection === null) {
+			throw new \PHPStan\ShouldNotHappenException();
+		}
+		if (!$classReflection->isFinal()) {
 			return [];
 		}
 
@@ -38,9 +43,8 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		$className = (string) $node->namespacedName;
 		try {
-			if ($objectManager->getMetadataFactory()->isTransient($className)) {
+			if ($objectManager->getMetadataFactory()->isTransient($classReflection->getName())) {
 				return [];
 			}
 		} catch (\ReflectionException $e) {
@@ -49,7 +53,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		return [sprintf(
 			'Entity class %s is final which can cause problems with proxies.',
-			$className
+			$classReflection->getDisplayName()
 		)];
 	}
 

src/Rules/Doctrine/ORM/PropertiesExtension.php

@@ -28,6 +28,9 @@ public function isAlwaysRead(PropertyReflection $property, string $propertyName)
 		return $metadata->hasField($propertyName) || $metadata->hasAssociation($propertyName);
 	}
 
+	/**
+	 * @param class-string $className
+	 */
 	private function findMetadata(string $className): ?\Doctrine\ORM\Mapping\ClassMetadataInfo
 	{
 		$objectManager = $this->objectMetadataResolver->getObjectManager();

src/Rules/Doctrine/ORM/RepositoryMethodCallRule.php

@@ -58,7 +58,10 @@ public function processNode(Node $node, Scope $scope): array
 		if (!$entityClassType instanceof TypeWithClassName) {
 			return [];
 		}
-		$entityClass = $entityClassType->getClassName();
+		$entityClassReflection = $entityClassType->getClassReflection();
+		if ($entityClassReflection === null) {
+			return [];
+		}
 
 		$methodNameIdentifier = $node->name;
 		if (!$methodNameIdentifier instanceof Node\Identifier) {
@@ -79,7 +82,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		$classMetadata = $objectManager->getClassMetadata($entityClass);
+		$classMetadata = $objectManager->getClassMetadata($entityClassReflection->getName());
 
 		$messages = [];
 		foreach ($argType->getKeyTypes() as $keyType) {
@@ -99,7 +102,7 @@ public function processNode(Node $node, Scope $scope): array
 				'Call to method %s::%s() - entity %s does not have a field named $%s.',
 				$calledOnType->describe(VerbosityLevel::typeOnly()),
 				$methodName,
-				$entityClass,
+				$entityClassReflection->getDisplayName(),
 				$fieldName
 			);
 		}

src/Type/Doctrine/ObjectMetadataResolver.php

@@ -103,7 +103,7 @@ public function getRepositoryClass(string $className): string
 			return $this->getResolvedRepositoryClass();
 		}
 
-		$metadata = $objectManager->getClassMetadata($className);
+		$metadata = $objectManager->getClassMetadata($classReflection->getName());
 
 		$ormMetadataClass = 'Doctrine\ORM\Mapping\ClassMetadata';
 		if ($metadata instanceof $ormMetadataClass) {