DecimalType - writes numeric-string

Author: ondrejmirtes

src/Type/Doctrine/Descriptors/DecimalType.php

@@ -2,6 +2,7 @@
 
 namespace PHPStan\Type\Doctrine\Descriptors;
 
+use PHPStan\Type\Accessory\AccessoryNumericStringType;
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;
 
@@ -15,7 +16,7 @@ public function getType(): string
 
 	public function getWritableToPropertyType(): Type
 	{
-		return new \PHPStan\Type\StringType();
+		return TypeCombinator::intersect(new \PHPStan\Type\StringType(), new AccessoryNumericStringType());
 	}
 
 	public function getWritableToDatabaseType(): Type

tests/Rules/Doctrine/ORM/EntityColumnRuleTest.php

@@ -13,6 +13,7 @@
 use PHPStan\Type\Doctrine\Descriptors\DateTimeImmutableType;
 use PHPStan\Type\Doctrine\Descriptors\DateTimeType;
 use PHPStan\Type\Doctrine\Descriptors\DateType;
+use PHPStan\Type\Doctrine\Descriptors\DecimalType;
 use PHPStan\Type\Doctrine\Descriptors\IntegerType;
 use PHPStan\Type\Doctrine\Descriptors\Ramsey\UuidTypeDescriptor;
 use PHPStan\Type\Doctrine\Descriptors\ReflectionDescriptor;
@@ -48,6 +49,7 @@ protected function getRule(): Rule
 				new DateType(),
 				new UuidTypeDescriptor(UuidType::class),
 				new ArrayType(),
+				new DecimalType(),
 			]),
 			true
 		);

tests/Rules/Doctrine/ORM/data/MyBrokenEntity.php

@@ -101,4 +101,22 @@ class MyBrokenEntity extends MyBrokenSuperclass
 	 */
 	private $arrayOfIntegersOrNull;
 
+	/**
+	 * @ORM\Column(type="decimal")
+	 * @var int|float|numeric-string
+	 */
+	private $decimal;
+
+	/**
+	 * @ORM\Column(type="decimal")
+	 * @var int|float|string
+	 */
+	private $decimalWithString;
+
+	/**
+	 * @ORM\Column(type="decimal")
+	 * @var string
+	 */
+	private $decimalWithString2;
+
 }