Use TypeSystem in AssertSameBooleanExpectedRule

Author: staabm

src/Rules/PHPUnit/AssertSameBooleanExpectedRule.php

@@ -40,18 +40,19 @@ public function processNode(Node $node, Scope $scope): array
 		if (!($expectedArgumentValue instanceof ConstFetch)) {
 			return [];
 		}
+		$expectedArgumentType = $scope->getType($expectedArgumentValue);
 
 		if (!AssertRuleHelper::isMethodOrStaticCallOnAssert($node, $scope)) {
 			return [];
 		}
 
-		if ($expectedArgumentValue->name->toLowerString() === 'true') {
+		if ($expectedArgumentType->isTrue()->yes()) {
 			return [
 				RuleErrorBuilder::message('You should use assertTrue() instead of assertSame() when expecting "true"')->identifier('phpunit.assertTrue')->build(),
 			];
 		}
 
-		if ($expectedArgumentValue->name->toLowerString() === 'false') {
+		if ($expectedArgumentType->isFalse()->yes()) {
 			return [
 				RuleErrorBuilder::message('You should use assertFalse() instead of assertSame() when expecting "false"')->identifier('phpunit.assertFalse')->build(),
 			];

tests/Rules/PHPUnit/AssertSameBooleanExpectedRuleTest.php

@@ -31,6 +31,14 @@ public function testRule(): void
 				'You should use assertTrue() instead of assertSame() when expecting "true"',
 				26,
 			],
+			[
+				'You should use assertTrue() instead of assertSame() when expecting "true"',
+				31,
+			],
+			[
+				'You should use assertFalse() instead of assertSame() when expecting "false"',
+				32,
+			],
 			[
 				'You should use assertTrue() instead of assertSame() when expecting "true"',
 				74,