implement CompositeRule

Author: staabm

tests/PHPStan/Rules/CompositeRule.php

@@ -0,0 +1,34 @@
+<?php
+
+namespace PHPStan\Rules;
+
+use PhpParser\Node;
+use PHPStan\Analyser\Scope;
+
+class CompositeRule implements Rule {
+	private DirectRegistry $registry;
+
+	public function __construct(DirectRegistry $ruleRegisty) {
+		$this->registry = $ruleRegisty;
+	}
+
+
+	public function getNodeType(): string
+	{
+		return Node::class;
+	}
+
+	public function processNode(Node $node, Scope $scope): array
+	{
+		$errors = [];
+
+		$nodeType = get_class($node);
+		foreach ($this->registry->getRules($nodeType) as $rule) {
+			foreach ($rule->processNode($node, $scope) as $error) {
+				$errors[] = $error;
+			}
+		}
+
+		return $errors;
+	}
+}

tests/Rules/PHPUnit/DataProviderDataRuleTest.php

@@ -2,8 +2,17 @@
 
 namespace Rules\PHPUnit;
 
+use PHPStan\Rules\CompositeRule;
+use PHPStan\Rules\DirectRegistry;
+use PHPStan\Rules\FunctionCallParametersCheck;
+use PHPStan\Rules\Methods\CallMethodsRule;
+use PHPStan\Rules\Methods\MethodCallCheck;
+use PHPStan\Rules\NullsafeCheck;
+use PHPStan\Rules\PhpDoc\UnresolvableTypeHelper;
 use PHPStan\Rules\PHPUnit\DataProviderDataRule;
+use PHPStan\Rules\Properties\PropertyReflectionFinder;
 use PHPStan\Rules\Rule;
+use PHPStan\Rules\RuleLevelHelper;
 use PHPStan\Testing\RuleTestCase;
 
 /**
@@ -14,23 +23,32 @@ class DataProviderDataRuleTest extends RuleTestCase
 
 	protected function getRule(): Rule
 	{
-		$reflection = $this->createReflectionProvider();
+		$reflectionProvider = $this->createReflectionProvider();
 
-		return new DataProviderDataRule(
-			$reflection
-		);
+		$ruleLevelHelper = new RuleLevelHelper($reflectionProvider, true, false, true, true, false, false, true);
+
+
+		return new CompositeRule(new DirectRegistry([
+			new DataProviderDataRule(
+				$reflectionProvider
+			),
+			new CallMethodsRule(
+				new MethodCallCheck($reflectionProvider, $ruleLevelHelper, true, true),
+				new FunctionCallParametersCheck($ruleLevelHelper, new NullsafeCheck(), new UnresolvableTypeHelper(), new PropertyReflectionFinder(), true, true, true, true),
+			)
+		]));
 	}
 
 	public function testRule(): void
 	{
 		$this->analyse([__DIR__ . '/data/data-provider-data.php'], [
 			[
-				'Parameter #2 $input of method test::testTrim() expects string, int given.',
-				25,
+				'Parameter #2 $input of method DataProviderDataTest\FooTest::testTrim() expects string, int given.',
+				23,
 			],
 			[
-				'Parameter #2 $input of method test::testTrim() expects string, false given.',
-				29,
+				'Parameter #2 $input of method DataProviderDataTest\FooTest::testTrim() expects string, false given.',
+				27,
 			],
 		]);
 	}

tests/Rules/PHPUnit/data/data-provider-data.php

@@ -13,7 +13,7 @@ public function testTrim(string $expectedResult, string $input): void
 	{
 	}
 
-	public function aProvider(): array /** @phpstan-ignore missingType.iterableValue */
+	public function aProvider(): array
 	{
 		return [
 			[