Add non regression tests for strict rules issues

Author: VincentLanglet

tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeFunctionCallRuleTest.php

@@ -1007,6 +1007,18 @@ public function testBug12755(): void
 		]);
 	}
 
+	public function testBugStrictRule147(): void
+	{
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->analyse([__DIR__ . '/data/bug-strict-147.php'], []);
+	}
+
+	public function testBugStrictRule143(): void
+	{
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->analyse([__DIR__ . '/data/bug-strict-143.php'], []);
+	}
+
 	public function testBug12412(): void
 	{
 		$this->treatPhpDocTypesAsCertain = true;

tests/PHPStan/Rules/Comparison/data/bug-strict-143.php

@@ -0,0 +1,7 @@
+<?php declare(strict_types = 1);
+
+namespace BugStrict143;
+
+function foo(string $key, array $arr): void {
+	$found = array_key_exists($key . 'foo', $arr) && array_key_exists($key . 'bar', $arr);
+}

tests/PHPStan/Rules/Comparison/data/bug-strict-147.php

@@ -0,0 +1,9 @@
+<?php declare(strict_types = 1);
+
+namespace BugStrict147;
+
+$array = ['a', 'c', 'b'];
+asort($array);
+if (array_is_list($array)) {
+	print 'array was in order';
+}