Skip to content

Commit 4bfa42f

Browse files
committed
simplify
1 parent 7981602 commit 4bfa42f

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

src/Rules/TooWideTypehints/TooWideTypeCheck.php

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -182,23 +182,13 @@ public function checkFunctionReturnType(
182182
}
183183

184184
$returnTypes = [];
185-
$returnsLiteralTrueFalse = [];
186185
foreach ($returnStatements as $returnStatement) {
187186
$returnNode = $returnStatement->getReturnNode();
188187
if ($returnNode->expr === null) {
189188
$returnTypes[] = new VoidType();
190189
continue;
191190
}
192191

193-
if (
194-
$returnNode->expr instanceof ConstFetch
195-
&& in_array(strtolower($returnNode->expr->name->toString()), ['true', 'false'], true)
196-
) {
197-
$returnsLiteralTrueFalse[] = TrinaryLogic::createYes();
198-
} else {
199-
$returnsLiteralTrueFalse[] = TrinaryLogic::createNo();
200-
}
201-
202192
$returnTypes[] = $returnStatement->getScope()->getType($returnNode->expr);
203193
}
204194

@@ -221,8 +211,8 @@ public function checkFunctionReturnType(
221211

222212
if (
223213
count($returnStatements) === 1
224-
&& $returnsLiteralTrueFalse !== []
225-
&& TrinaryLogic::extremeIdentity(...$returnsLiteralTrueFalse)->yes()
214+
&& $returnStatements[0]->getReturnNode()->expr instanceof ConstFetch
215+
&& in_array(strtolower($returnStatements[0]->getReturnNode()->expr->name->toString()), ['true', 'false'], true)
226216
&& (
227217
$nativeFunctionReturnType->isBoolean()->yes()
228218
|| $phpDocFunctionReturnType->isBoolean()->yes()

0 commit comments

Comments
 (0)