Prevent duplicate work

staabm · staabm · commit 57ed25e73bd9 · 2025-11-06T20:27:41.000+01:00
diff --git a/src/Rules/Comparison/ImpossibleCheckTypeHelper.php b/src/Rules/Comparison/ImpossibleCheckTypeHelper.php
@@ -163,7 +163,7 @@ public function findSpecifiedType(
 											continue;
 										}
 
-										foreach ($haystackArrayValueType->getConstantScalarTypes() as $constantScalarType) {
+										foreach ($haystackArrayValueConstantScalarTypes as $constantScalarType) {
 											if ($constantScalarType->isSuperTypeOf($needleType)->yes()) {
 												continue 3;
 											}

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ public function findSpecifiedType(`
`163`	`163`	`continue;`
`164`	`164`	`}`
`165`	`165`
`166`		`- foreach ($haystackArrayValueType->getConstantScalarTypes() as $constantScalarType) {`
	`166`	`+ foreach ($haystackArrayValueConstantScalarTypes as $constantScalarType) {`
`167`	`167`	`if ($constantScalarType->isSuperTypeOf($needleType)->yes()) {`
`168`	`168`	`continue 3;`
`169`	`169`	`}`