simplify logic for the do-while(true) case; additional tests

Author: claudepache

src/Rules/Comparison/DoWhileLoopConstantConditionRule.php

@@ -44,24 +44,13 @@ public function processNode(Node $node, Scope $scope): array
 			if ($exprType->getValue()) {
 				foreach ($node->getExitPoints() as $exitPoint) {
 					$statement = $exitPoint->getStatement();
-					if ($statement instanceof Break_) {
-						return [];
-					}
 					if (!$statement instanceof Continue_) {
 						return [];
 					}
-					if ($statement->num === null) {
-						continue;
-					}
 					if (!$statement->num instanceof Int_) {
 						continue;
 					}
-					$value = $statement->num->value;
-					if ($value === 1) {
-						continue;
-					}
-
-					if ($value > 1) {
+					if ($statement->num->value > 1) {
 						return [];
 					}
 				}

tests/PHPStan/Rules/Comparison/DoWhileLoopConstantConditionRuleTest.php

@@ -59,6 +59,14 @@ public function testRule(): void
 				'Do-while loop condition is always false.',
 				115,
 			],
+			[
+				'Do-while loop condition is always false.',
+				138,
+			],
+			[
+				'Do-while loop condition is always false.',
+				152,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Comparison/data/do-while-loop.php

@@ -124,4 +124,32 @@ public function doFoo10(array $a)
 		} while (false); // do not report
 	}
 
+	public function doFoo11(array $a)
+	{
+		do {
+			throw new \Exception;
+		} while (true); // do not report
+	}
+
+	public function doFoo12(array $a)
+	{
+		do {
+			throw new \Exception;
+		} while (false); // report
+	}
+
+	public function doFoo13(array $a)
+	{
+		do {
+			exit;
+		} while (true); // do not report
+	}
+
+	public function doFoo12(array $a)
+	{
+		do {
+			exit;
+		} while (false); // report
+	}
+
 }