Fix restore/persist storage

Author: ondrejmirtes

src/Analyser/Generator/ExprHandler/NewHandler.php

@@ -173,7 +173,6 @@ public function analyseExpr(
 
 		if ($constructorReflection !== null) {
 			$storage = yield new PersistStorageRequest();
-			yield new RestoreStorageRequest($storage);
 			$parametersAcceptor = (yield new RunInFiberRequest(static fn () => ParametersAcceptorSelector::selectFromArgs(
 				$scope,
 				$expr->getArgs(),
@@ -231,7 +230,6 @@ private function processAnonymousClass(
 		if ($classReflection->hasConstructor()) {
 			$constructorReflection = $classReflection->getConstructor();
 			$storage = yield new PersistStorageRequest();
-			yield new RestoreStorageRequest($storage);
 			$parametersAcceptor = (yield new RunInFiberRequest(static fn () => ParametersAcceptorSelector::selectFromArgs(
 				$scope,
 				$expr->getArgs(),
@@ -399,7 +397,6 @@ private function exactInstantiation(GeneratorScope $scope, New_ $node, Name $cla
 		);
 
 		$storage = yield new PersistStorageRequest();
-		yield new RestoreStorageRequest($storage);
 		$parametersAcceptor = (yield new RunInFiberRequest(static fn () => ParametersAcceptorSelector::selectFromArgs(
 			$scope,
 			$methodCall->getArgs(),

src/Analyser/Generator/GeneratorNodeScopeResolver.php

@@ -252,14 +252,7 @@ private function runTrampoline(
 					$gen->generator->current();
 					continue;
 				} elseif ($yielded instanceof PersistStorageRequest) {
-					$stack[] = $gen;
-					$gen = new IdentifiedGeneratorInStack(
-						$this->persistStorage($exprAnalysisResultStorage),
-						new Stmt\Expression(new Node\Scalar\String_('fake')),
-						$yielded->originFile,
-						$yielded->originLine,
-					);
-					$gen->generator->current();
+					$gen->generator->send($exprAnalysisResultStorage->duplicate());
 					continue;
 				} elseif ($yielded instanceof RestoreStorageRequest) {
 					$exprAnalysisResultStorage = $yielded->storage->duplicate();
@@ -377,15 +370,6 @@ private function analyseAttrGroups(Stmt $stmt, array $attrGroups, GeneratorScope
 		yield from $handler->processAttributeGroups($stmt, $attrGroups, $scope, $alternativeNodeCallback);
 	}
 
-	/**
-	 * @return Generator<int, GeneratorTValueType, GeneratorTSendType, ExprAnalysisResultStorage>
-	 */
-	private function persistStorage(ExprAnalysisResultStorage $storage): Generator
-	{
-		yield from [];
-		return $storage;
-	}
-
 	/**
 	 * @template T
 	 * @param callable(): T $callback