Consider comparison as strict when type is the same

Author: VincentLanglet

src/Type/Php/InArrayFunctionTypeSpecifyingExtension.php

@@ -60,7 +60,11 @@ public function specifyTypes(FunctionReflection $functionReflection, FuncCall $n
 
 		$isStrictComparison = $isStrictComparison
 			|| $needleType->isEnum()->yes()
-			|| $arrayValueType->isEnum()->yes();
+			|| $arrayValueType->isEnum()->yes()
+			|| ($needleType->isString()->yes() && $arrayValueType->isString()->yes())
+			|| ($needleType->isInteger()->yes() && $arrayValueType->isInteger()->yes())
+			|| ($needleType->isFloat()->yes() && $arrayValueType->isFloat()->yes())
+			|| ($needleType->isBoolean()->yes() && $arrayValueType->isBoolean()->yes());
 
 		if ($arrayExpr instanceof Array_) {
 			$types = null;

tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php

@@ -3442,4 +3442,14 @@ public function testBug6828(): void
 		$this->analyse([__DIR__ . '/data/bug-6828.php'], []);
 	}
 
+	public function testBug12884(): void
+	{
+		$this->checkThisOnly = false;
+		$this->checkNullables = true;
+		$this->checkUnionTypes = true;
+		$this->checkExplicitMixed = true;
+
+		$this->analyse([__DIR__ . '/data/bug-12884.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Methods/data/bug-12884.php

@@ -0,0 +1,40 @@
+<?php declare(strict_types = 1);
+
+namespace Bug12884;
+
+class LogLevel
+{
+	const EMERGENCY = 'emergency';
+	const ALERT = 'alert';
+	const CRITICAL = 'critical';
+	const ERROR = 'error';
+	const WARNING = 'warning';
+	const NOTICE = 'notice';
+	const INFO = 'info';
+	const DEBUG = 'debug';
+}
+
+class HelloWorld
+{
+	/** @param list<LogLevel::*> $levels */
+	public function __construct(
+		private LoggerInterface $logger,
+		public array $levels = []
+	) {}
+
+	public function log(string $level, string $message): void
+	{
+		if (!in_array($level, $this->levels, true)) {
+			$level = LogLevel::INFO;
+		}
+		$this->logger->log($level, $message);
+	}
+}
+
+interface LoggerInterface
+{
+	/**
+	 * @param 'emergency'|'alert'|'critical'|'error'|'warning'|'notice'|'info'|'debug' $level
+	 */
+	public function log($level, string|\Stringable $message): void;
+}