InlineHTML is an impure point

Author: staabm

src/Analyser/ImpurePoint.php

@@ -6,7 +6,7 @@
 use PHPStan\Node\VirtualNode;
 
 /**
- * @phpstan-type ImpurePointIdentifier = 'echo'|'die'|'exit'|'propertyAssign'|'methodCall'|'new'|'functionCall'|'include'|'require'|'print'|'eval'|'superglobal'|'yield'|'yieldFrom'|'static'|'global'
+ * @phpstan-type ImpurePointIdentifier = 'echo'|'die'|'exit'|'propertyAssign'|'methodCall'|'new'|'functionCall'|'include'|'require'|'print'|'eval'|'superglobal'|'yield'|'yieldFrom'|'static'|'global'|'betweenPhpTags'
  * @api
  */
 class ImpurePoint

src/Analyser/NodeScopeResolver.php

@@ -43,6 +43,7 @@
 use PhpParser\Node\Stmt\For_;
 use PhpParser\Node\Stmt\Foreach_;
 use PhpParser\Node\Stmt\If_;
+use PhpParser\Node\Stmt\InlineHTML;
 use PhpParser\Node\Stmt\Return_;
 use PhpParser\Node\Stmt\Static_;
 use PhpParser\Node\Stmt\Switch_;
@@ -1804,6 +1805,12 @@ static function (Node $node, Scope $scope) use ($nodeCallback): void {
 				$exprResult = $this->processExprNode($stmt, $stmt->expr, $scope, $nodeCallback, ExpressionContext::createDeep());
 				$impurePoints = $exprResult->getImpurePoints();
 			}
+		} elseif ($stmt instanceof InlineHTML) {
+			$hasYield = false;
+			$throwPoints = [];
+			$impurePoints = [
+				new ImpurePoint($scope, $stmt, 'betweenPhpTags', 'output between PHP opening and closing tags', true),
+			];
 		} elseif ($stmt instanceof Node\Stmt\Nop) {
 			$hasYield = false;
 			$throwPoints = $overridingThrowPoints ?? [];

tests/PHPStan/Rules/Pure/PureFunctionRuleTest.php

@@ -100,6 +100,10 @@ public function testRule(): void
 				'Possibly impure call to a Closure in pure function PureFunction\callsClosures().',
 				140,
 			],
+			[
+				'Impure output between PHP opening and closing tags in pure function PureFunction\justContainsInlineHtml().',
+				160,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Pure/data/pure-function.php

@@ -151,3 +151,16 @@ function callsPureCallableIdentifierTypeNode(callable $cb, \Closure $closure): i
 	$cb();
 	$closure();
 }
+
+
+/** @phpstan-pure */
+function justContainsInlineHtml()
+{
+	?>
+	</td>
+	</tr>
+	</table></td>
+	</tr>
+	</table>
+	<?php
+}