Playground: Implement NonPhpdocCommentRule

Author: staabm

issue-bot/playground.neon

@@ -3,6 +3,7 @@ rules:
 	- PHPStan\Rules\Playground\MethodNeverRule
 	- PHPStan\Rules\Playground\NotAnalysedTraitRule
 	- PHPStan\Rules\Playground\NoPhpCodeRule
+	- PHPStan\Rules\Playground\PhpdocCommentRule
 
 conditionalTags:
 	PHPStan\Rules\Playground\StaticVarWithoutTypeRule:

src/Rules/Playground/PhpdocCommentRule.php

@@ -0,0 +1,55 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Playground;
+
+use PhpParser\Comment;
+use PhpParser\Node;
+use PHPStan\Analyser\Scope;
+use PHPStan\Node\VirtualNode;
+use PHPStan\Rules\Rule;
+use PHPStan\Rules\RuleErrorBuilder;
+use PHPStan\ShouldNotHappenException;
+use function str_contains;
+use function str_starts_with;
+
+/**
+ * @implements Rule<Node>
+ */
+final class PhpdocCommentRule implements Rule
+{
+
+	public function getNodeType(): string
+	{
+		return Node::class;
+	}
+
+	public function processNode(Node $node, Scope $scope): array
+	{
+		if ($node instanceof VirtualNode) {
+			return [];
+		}
+
+		$comments = $node->getAttribute('comments', []);
+
+		$errors = [];
+		foreach ($comments as $comment) {
+			if (!$comment instanceof Comment) {
+				throw new ShouldNotHappenException();
+			}
+			if (!str_contains($comment->getText(), '@')) {
+				continue;
+			}
+
+			if (str_starts_with($comment->getText(), '/**')) {
+				continue;
+			}
+
+			$errors[] =	RuleErrorBuilder::message('Comment contains phpdoc-tag but does not start with /** tag.')
+				->identifier('phpstanPlayground.noPhpdoc')
+				->build();
+		}
+
+		return $errors;
+	}
+
+}

tests/PHPStan/Rules/Playground/PhpdocCommentRuleTest.php

@@ -0,0 +1,33 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Playground;
+
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+
+/**
+ * @extends RuleTestCase<PhpdocCommentRule>
+ */
+class PhpdocCommentRuleTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new PhpdocCommentRule();
+	}
+
+	public function testRule(): void
+	{
+		$this->analyse([__DIR__ . '/data/comments.php'], [
+			[
+				'Comment contains phpdoc-tag but does not start with /** tag.',
+				13,
+			],
+			[
+				'Comment contains phpdoc-tag but does not start with /** tag.',
+				23,
+			],
+		]);
+	}
+
+}

tests/PHPStan/Rules/Playground/data/comments.php

@@ -0,0 +1,35 @@
+<?php
+
+namespace CommentTypes;
+
+/**
+ * @template T of FooInterface
+ */
+class Bar
+{
+	/*
+	 * @var T $foo
+	 */
+	protected FooInterface $foo;
+
+	/**
+	 * @param T $foo
+	 */
+	public function __construct(FooInterface $foo) { $this->foo = $foo; }
+
+	/*
+	 * @return T
+	 */
+	public function getFoo(): FooInterface
+	{
+		return $this->foo;
+	}
+
+	/*
+	 * some method
+	 */
+	public function getBar(): FooInterface
+	{
+		return $this->foo;
+	}
+}