Implements isSuperTypeOf

Author: VincentLanglet

src/Type/StringNeverAcceptingObjectWithToStringType.php

@@ -5,6 +5,20 @@
 class StringNeverAcceptingObjectWithToStringType extends StringType
 {
 
+	public function isSuperTypeOf(Type $type): IsSuperTypeOfResult
+	{
+		if ($type instanceof CompoundType) {
+			return $type->isSubTypeOf($this);
+		}
+
+		$result = parent::isSuperTypeOf($type);
+		if (!$type instanceof self) {
+			$result = $result->and(IsSuperTypeOfResult::createMaybe());
+		}
+
+		return $result;
+	}
+
 	public function accepts(Type $type, bool $strictTypes): AcceptsResult
 	{
 		return parent::accepts($type, true);

tests/PHPStan/Type/TypeCombinatorTest.php

@@ -51,6 +51,7 @@
 use PHPUnit\Framework\Attributes\DataProvider;
 use RecursionCallable\Foo;
 use stdClass;
+use Stringable;
 use Test\ClassWithNullableProperty;
 use Test\ClassWithToString;
 use Test\FirstInterface;
@@ -2141,6 +2142,30 @@ public static function dataUnion(): iterable
 				MixedType::class,
 				'mixed=implicit',
 			],
+			[
+				[
+					new StringAlwaysAcceptingObjectWithToStringType(),
+					new StringType(),
+				],
+				StringAlwaysAcceptingObjectWithToStringType::class,
+				'string'
+			],
+			[
+				[
+					new StringNeverAcceptingObjectWithToStringType(),
+					new StringType(),
+				],
+				StringType::class,
+				'string'
+			],
+			[
+				[
+					new StringNeverAcceptingObjectWithToStringType(),
+					new StringAlwaysAcceptingObjectWithToStringType(),
+				],
+				StringAlwaysAcceptingObjectWithToStringType::class,
+				'string'
+			],
 		];
 
 		if (PHP_VERSION_ID < 80100) {
@@ -4159,6 +4184,46 @@ public static function dataIntersect(): iterable
 				ObjectType::class,
 				'stdClass',
 			],
+			[
+				[
+					new StringAlwaysAcceptingObjectWithToStringType(),
+					new ObjectType(Stringable::class),
+				],
+				ObjectType::class,
+				'Stringable',
+			],
+			[
+				[
+					new StringNeverAcceptingObjectWithToStringType(),
+					new ObjectType(Stringable::class),
+				],
+				NeverType::class,
+				'*NEVER*=implicit',
+			],
+			[
+				[
+					new StringNeverAcceptingObjectWithToStringType(),
+					new StringAlwaysAcceptingObjectWithToStringType(),
+				],
+				StringNeverAcceptingObjectWithToStringType::class,
+				'string',
+			],
+			[
+				[
+					new StringNeverAcceptingObjectWithToStringType(),
+					new StringType(),
+				],
+				StringNeverAcceptingObjectWithToStringType::class,
+				'string',
+			],
+			[
+				[
+					new StringAlwaysAcceptingObjectWithToStringType(),
+					new StringType(),
+				],
+				StringType::class,
+				'string',
+			],
 		];
 
 		if (PHP_VERSION_ID < 80100) {