Test ReturnNullsafeByRefRule with property hooks

Author: ondrejmirtes

tests/PHPStan/Rules/Functions/ReturnNullsafeByRefRuleTest.php

@@ -5,6 +5,7 @@
 use PHPStan\Rules\NullsafeCheck;
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
+use const PHP_VERSION_ID;
 
 /**
  * @extends RuleTestCase<ReturnNullsafeByRefRule>
@@ -35,4 +36,18 @@ public function testRule(): void
 		]);
 	}
 
+	public function testPropertyHooks(): void
+	{
+		if (PHP_VERSION_ID < 80400) {
+			$this->markTestSkipped('Test requires PHP 8.4.');
+		}
+
+		$this->analyse([__DIR__ . '/data/return-null-safe-by-ref-property-hooks.php'], [
+			[
+				'Nullsafe cannot be returned by reference.',
+				13,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Functions/data/return-null-safe-by-ref-property-hooks.php

@@ -0,0 +1,16 @@
+<?php // lint >= 8.4
+
+namespace ReturnNullSafeByRefPropertyHools;
+
+use stdClass;
+
+class Foo
+{
+	public int $i {
+		&get {
+			$foo = new stdClass();
+
+			return $foo?->foo;
+		}
+	}
+}