Playground: Implement PhpdocCommentRule #4074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
changed the title
clxmstaab
force-pushed
the
NonPhpdocCommentRule
branch
from
c033db6 to
c495d3d
Compare
staabm
commented
Jun 26, 2025
Collaborator
|
This pull request has been marked as ready for review. |
staabm
force-pushed
the
NonPhpdocCommentRule
branch
from
1c8c478 to
36d28d7
Compare
ondrejmirtes
requested changes
Jul 17, 2025
|
|
||
| public function getNodeType(): string | ||
| { | ||
| return Node::class; |
Member
There was a problem hiding this comment.
I'd do it only for Node\Stmt.
Contributor
Author
There was a problem hiding this comment.
tbh there are so many different node types, that I don't know what the differences are in this case.
adjusted it per request :)
ondrejmirtes
requested changes
Jul 17, 2025
| use function str_starts_with; | ||
|
|
||
| /** | ||
| * @implements Rule<Node> |
Member
There was a problem hiding this comment.
Not synced with getNodeType
Member
|
Thank you. Please add it to https://github.com/phpstan/phpstan/blob/2.1.x/playground-runner/playground.neon once it's built. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in phpstan/phpstan#13189 (reply in thread)