Skip to content

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Sep 30, 2025

issue-bot currently misses these errors/fixes, see #4381 (comment)

1:1 copy of the config from https://github.com/phpstan/phpstan/blob/2.1.x/playground-runner/playground.neon

@staabm
Copy link
Contributor Author

staabm commented Sep 30, 2025

hmm thinking again.. maybe we should just enable the optional rules in issue bot..?

or maybe even just enable bleeding edge?

@staabm
Copy link
Contributor Author

staabm commented Sep 30, 2025

.. hmm reflecting the playground settings 1:1 seems to be the most intuive fix, which is also reasonable for the end-user (least suprising)

@staabm staabm marked this pull request as ready for review September 30, 2025 15:34
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@ondrejmirtes
Copy link
Member

  1. I didn't do this on purpose because I'm afraid that dozens, or maybe even hundreds of comments would spam the issue tracker when this would get enabled.
  2. You don't see any changes now because these rules are also filtered in code
    $errors = array_values(array_filter($errors, static fn (PlaygroundError $error) => $error->getIdentifier() !== 'phpstanPlayground.configParameter'));

@staabm staabm closed this Oct 2, 2025
@staabm staabm deleted the prom branch October 2, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants