From 57ed25e73bd9725b1fe3da824385d92e0fd3bde6 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Thu, 6 Nov 2025 20:27:41 +0100 Subject: [PATCH 1/2] Prevent duplicate work --- src/Rules/Comparison/ImpossibleCheckTypeHelper.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Rules/Comparison/ImpossibleCheckTypeHelper.php b/src/Rules/Comparison/ImpossibleCheckTypeHelper.php index 7d6585ebaf..696707826a 100644 --- a/src/Rules/Comparison/ImpossibleCheckTypeHelper.php +++ b/src/Rules/Comparison/ImpossibleCheckTypeHelper.php @@ -163,7 +163,7 @@ public function findSpecifiedType( continue; } - foreach ($haystackArrayValueType->getConstantScalarTypes() as $constantScalarType) { + foreach ($haystackArrayValueConstantScalarTypes as $constantScalarType) { if ($constantScalarType->isSuperTypeOf($needleType)->yes()) { continue 3; } From d637273bcb9b0fd73b8428a47dc18ca1c24e2aeb Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Thu, 6 Nov 2025 20:42:51 +0100 Subject: [PATCH 2/2] remove dead code --- src/Rules/Comparison/ImpossibleCheckTypeHelper.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Rules/Comparison/ImpossibleCheckTypeHelper.php b/src/Rules/Comparison/ImpossibleCheckTypeHelper.php index 696707826a..b353e7f60d 100644 --- a/src/Rules/Comparison/ImpossibleCheckTypeHelper.php +++ b/src/Rules/Comparison/ImpossibleCheckTypeHelper.php @@ -154,7 +154,7 @@ public function findSpecifiedType( foreach ($haystackArrayTypes as $haystackArrayType) { if ($haystackArrayType instanceof ConstantArrayType) { foreach ($haystackArrayType->getValueTypes() as $i => $haystackArrayValueType) { - if (count($haystackArrayValueType->getFiniteTypes()) > 1 || $haystackArrayType->isOptionalKey($i)) { + if ($haystackArrayType->isOptionalKey($i)) { continue; }