diff --git a/src/Analyser/Generator/ExprHandler/BitwiseXorHandler.php b/src/Analyser/Generator/ExprHandler/BitwiseXorHandler.php new file mode 100644 index 0000000000..f753faa083 --- /dev/null +++ b/src/Analyser/Generator/ExprHandler/BitwiseXorHandler.php @@ -0,0 +1,53 @@ + + */ +#[AutowiredService] +final class BitwiseXorHandler implements ExprHandler +{ + + public function __construct(private InitializerExprTypeResolver $initializerExprTypeResolver) + { + } + + public function supports(Expr $expr): bool + { + return $expr instanceof Expr\BinaryOp\BitwiseXor; + } + + public function analyseExpr(Stmt $stmt, Expr $expr, GeneratorScope $scope, ExpressionContext $context, ?callable $alternativeNodeCallback): Generator + { + $leftResult = yield new ExprAnalysisRequest($stmt, $expr->left, $scope, $context, $alternativeNodeCallback); + $rightResult = yield new ExprAnalysisRequest($stmt, $expr->right, $leftResult->scope, $context, $alternativeNodeCallback); + + return new ExprAnalysisResult( + $this->initializerExprTypeResolver->getBitwiseXorTypeFromTypes($leftResult->type, $rightResult->type), + $this->initializerExprTypeResolver->getBitwiseXorTypeFromTypes($leftResult->nativeType, $rightResult->nativeType), + $rightResult->scope, + hasYield: $leftResult->hasYield || $rightResult->hasYield, + isAlwaysTerminating: $leftResult->isAlwaysTerminating || $rightResult->isAlwaysTerminating, + throwPoints: array_merge($leftResult->throwPoints, $rightResult->throwPoints), + impurePoints: array_merge($leftResult->impurePoints, $rightResult->impurePoints), + specifiedTruthyTypes: new SpecifiedTypes(), + specifiedFalseyTypes: new SpecifiedTypes(), + specifiedNullTypes: new SpecifiedTypes(), + ); + } + +} diff --git a/src/Reflection/InitializerExprTypeResolver.php b/src/Reflection/InitializerExprTypeResolver.php index 3bd59c0b10..edecd59552 100644 --- a/src/Reflection/InitializerExprTypeResolver.php +++ b/src/Reflection/InitializerExprTypeResolver.php @@ -1092,6 +1092,11 @@ public function getBitwiseXorType(Expr $left, Expr $right, callable $getTypeCall $leftType = $getTypeCallback($left); $rightType = $getTypeCallback($right); + return $this->getBitwiseXorTypeFromTypes($leftType, $rightType); + } + + public function getBitwiseXorTypeFromTypes(Type $leftType, Type $rightType): Type + { if ($leftType instanceof NeverType || $rightType instanceof NeverType) { return $this->getNeverType($leftType, $rightType); } diff --git a/tests/PHPStan/Analyser/Generator/data/gnsr.php b/tests/PHPStan/Analyser/Generator/data/gnsr.php index 60e78e87ca..41b5c47d24 100644 --- a/tests/PHPStan/Analyser/Generator/data/gnsr.php +++ b/tests/PHPStan/Analyser/Generator/data/gnsr.php @@ -117,6 +117,21 @@ public function doBitwiseOr($a, $b, int $c, int $d): void assertNativeType('int', $c | $d); } + /** + * @param int $a + * @param int $b + * @return void + */ + public function doBitwiseXor($a, $b, int $c, int $d): void + { + assertType('int', $a ^ $b); + assertNativeType('int', $a ^ $b); + assertType('0', 1 ^ 1); + assertNativeType('0', 1 ^ 1); + assertType('int', $c ^ $d); + assertNativeType('int', $c ^ $d); + } + /** * @param int $a * @param int $b