get rid of todo comments in \PHPStan\Symfony\MessageMapFactory::guessHandledMessages

Author: Bartłomiej Nowak

src/Symfony/MessageMapFactory.php

@@ -3,16 +3,15 @@
 namespace PHPStan\Symfony;
 
 use PHPStan\Reflection\ClassReflection;
+use PHPStan\Reflection\MissingMethodFromReflectionException;
 use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\Reflection\ReflectionProvider;
-use RuntimeException;
 use Symfony\Component\Messenger\Handler\MessageSubscriberInterface;
 use function count;
 use function is_int;
 use function is_null;
 use function is_string;
 
-// todo add tests
 final class MessageMapFactory
 {
 
@@ -94,23 +93,30 @@ private function guessHandledMessages(ClassReflection $reflectionClass): iterabl
 			return;
 		}
 
-		// todo handle if doesn't exists
-		$methodReflection = $reflectionClass->getNativeMethod(self::DEFAULT_HANDLER_METHOD);
+		try {
+			$methodReflection = $reflectionClass->getNativeMethod(self::DEFAULT_HANDLER_METHOD);
+		} catch (MissingMethodFromReflectionException $e) {
+			return;
+		}
+
+		$variants = $methodReflection->getVariants();
+		if (count($variants) !== 1) {
+			return;
+		}
 
-		$variant = ParametersAcceptorSelector::selectSingle($methodReflection->getVariants());
-		$parameters = $variant->getParameters();
+		$parameters = $variants[0]->getParameters();
 
 		if (count($parameters) !== 1) {
-			// todo handle error
-			throw new RuntimeException('invalid handler');
+			return;
 		}
 
-		$type = $parameters[0]->getType();
+		$classNames = $parameters[0]->getType()->getObjectClassNames();
 
-		// todo many class names?
-		foreach ($type->getObjectClassNames() as $className) {
-			yield $className => ['method' => self::DEFAULT_HANDLER_METHOD];
+		if (count($classNames) !== 1) {
+			return;
 		}
+
+		yield $classNames[0] => ['method' => self::DEFAULT_HANDLER_METHOD];
 	}
 
 }

src/Type/Symfony/MessengerHandleTraitReturnTypeExtension.php

@@ -33,15 +33,6 @@ public function __construct(MessageMapFactory $symfonyMessageMapFactory)
 
 	public function getType(Expr $expr, Scope $scope): ?Type
 	{
-		// todo handle different cases:
-		//  - [X] regular message classes
-		//  - [ ] interfaces for message classes
-		//  - [ ] many handlers for one message? it would throw exception in HandleTrait anyway
-		//  - [x] many messages for one handler
-		//  - [partially] cover MessageSubscriberInterface
-		//  - [partially] custom method names for handlers (different than default "__invoke" magic method)
-		//  - [] read SF doc to determine any other cases to covers
-
 		if ($this->isSupported($expr, $scope)) {
 			$arg = $expr->getArgs()[0]->value;
 			$argClassNames = $scope->getType($arg)->getObjectClassNames();