Skip to content

Commit 11bd420

Browse files
committed
some fixes
1 parent f2ae0fc commit 11bd420

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

performance-tests/src/test/scala/pl/piomin/performance/tests/CreateAndPayTripPerformanceTest.scala

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,14 @@ class CreateAndPayTripPerformanceTest extends Simulation {
2020
.body(StringBody("""{"destination":"test${n}","locationX":${n},"locationY":${n},"username":"${passenger}"}"""))
2121
.check(status.is(200), jsonPath("$.id").saveAs("tripId"))
2222
).exec(http("PayTrip-API")
23-
.put("http://localhost:8090/trips/${tripId}")
23+
.put("http://localhost:8090/trips/payment/${tripId}")
2424
.header("Content-Type", "application/json")
2525
.check(status.is(200))
26-
).pause(FiniteDuration.apply(10, TimeUnit.MILLISECONDS))
26+
)
27+
// .pause(FiniteDuration.apply(10, TimeUnit.MILLISECONDS))
2728
}
2829

2930
setUp(scn.inject(atOnceUsers(20))).maxDuration(FiniteDuration.apply(5, TimeUnit.MINUTES))
30-
.assertions(global.responseTime.max.lt(50))
31+
// .assertions(global.responseTime.max.lt(100))
3132

3233
}

trip-management/src/main/java/pl/piomin/services/trip/controller/TripController.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,10 @@ public Trip create(@RequestBody TripInput tripInput) {
4343
trip.setLocationY(passenger.getHomeLocationY());
4444
driver = driverManagementClient.getNearestDriver(tripInput.getLocationX(), tripInput.getLocationY());
4545
}
46+
if (driver == null) {
47+
trip.setStatus(TripStatus.REJECTED);
48+
return trip;
49+
}
4650
trip.setDriverId(driver.getId());
4751
trip.setStatus(TripStatus.NEW);
4852
trip.setStartTime(System.currentTimeMillis());
@@ -71,8 +75,8 @@ public Trip payment(@PathVariable("id") Long id) {
7175
Trip trip = repository.findById(id);
7276
long duration = System.currentTimeMillis() - trip.getStartTime();
7377
trip.setPrice((int) (duration / 1000));
74-
passengerManagementClient.updatePassenger(new PassengerInput(id, (-1) * trip.getPrice()));
75-
driverManagementClient.updateDriver(new DriverInput(trip.getDriverId(), DriverStatus.AVAIlABLE, trip.getPrice()));
78+
passengerManagementClient.updatePassenger(new PassengerInput(trip.getPassengerId(), (-1) * trip.getPrice()));
79+
driverManagementClient.updateDriver(new DriverInput(trip.getDriverId(), DriverStatus.AVAILABLE, trip.getPrice()));
7680
trip.setStatus(TripStatus.PAYED);
7781
return repository.update(trip);
7882
}

trip-management/src/main/java/pl/piomin/services/trip/model/DriverStatus.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22

33
public enum DriverStatus {
44

5-
AVAIlABLE, UNAVAILABLE;
5+
AVAILABLE, UNAVAILABLE;
66
}

0 commit comments

Comments
 (0)