Apply suggestions from code review

Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>

Author: emilykl

src/components/fx/hover.js

@@ -1665,7 +1665,7 @@ function getHoverLabelText(d, showCommonLabel, hovermode, fullLayout, t0, g) {
     // Ignore hovertemplate if hoverlabel.split is set
     // This ensures correct behavior of hoverlabel.split for candlestick and OHLC traces
     // Not very elegant but it works
-    if (d.trace?.hoverlabel?.split) d.hovertemplate = false;
+    if (d.trace?.hoverlabel?.split) d.hovertemplate = '';
 
     const { hovertemplate = false } = d;
     if (hovertemplate) {

src/traces/candlestick/attributes.js

@@ -2,8 +2,6 @@
 
 var extendFlat = require('../../lib').extendFlat;
 var axisHoverFormat = require('../../plots/cartesian/axis_format_attributes').axisHoverFormat;
-var hovertemplateAttrs = require('../../plots/template_attributes').hovertemplateAttrs;
-var templatefallbackAttrs = require('../../plots/template_attributes').templatefallbackAttrs;
 var OHLCattrs = require('../ohlc/attributes');
 var boxAttrs = require('../box/attributes');
 

src/traces/ohlc/attributes.js

@@ -2,10 +2,8 @@
 
 var extendFlat = require('../../lib').extendFlat;
 var scatterAttrs = require('../scatter/attributes');
-var baseAttrs = require('../../plots/attributes');
 var axisHoverFormat = require('../../plots/cartesian/axis_format_attributes').axisHoverFormat;
-var hovertemplateAttrs = require('../../plots/template_attributes').hovertemplateAttrs;
-var templatefallbackAttrs = require('../../plots/template_attributes').templatefallbackAttrs;
+const { hovertemplateAttrs, templatefallbackAttrs } = require('../../plots/template_attributes');
 var dash = require('../../components/drawing/attributes').dash;
 var fxAttrs = require('../../components/fx/attributes');
 var delta = require('../../constants/delta.js');