BUG: Replaced ValueError exception with TypeError exception in df.where() function (pandas-dev#56495)

* Replaced ValueError exception with TypeError exception in df.where() function

Replaced ValueError exception with TypeError as it is more appropriate for the error it serves.

* Updated test_where.py to account for updated exceptions.

* Update test_indexing.py to account for modified exceptions

* Update test_where.py for series

* Added bug fix to v2.2.0.rst

* Updated v2.2.0.rst

* Updated v2.2.0.rst

* Updated v2.2.0.rst

* Updated v2.2.0.rst

* Updated v2.2.0.rst

* resolved merge conflict

* resolved conflicts again

* Updated v2.2.0.rst

* Updated v2.2.0.rst

* removed change from 2.20

* Update v2.3.0.rst

* Update doc/source/whatsnew/v2.3.0.rst

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>

---------

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>

Author: 2 people

doc/source/whatsnew/v2.3.0.rst

@@ -211,6 +211,8 @@ Styler
 
 Other
 ^^^^^
+- Bug in :meth:`DataFrame.where` where using a non-bool type array in the function would return a ``ValueError`` instead of a ``TypeError`` (:issue:`56330`)
+
 
 .. ***DO NOT USE THIS SECTION***
 

pandas/core/generic.py

@@ -10675,11 +10675,11 @@ def _where(
             if not isinstance(cond, ABCDataFrame):
                 # This is a single-dimensional object.
                 if not is_bool_dtype(cond):
-                    raise ValueError(msg.format(dtype=cond.dtype))
+                    raise TypeError(msg.format(dtype=cond.dtype))
             else:
                 for _dt in cond.dtypes:
                     if not is_bool_dtype(_dt):
-                        raise ValueError(msg.format(dtype=_dt))
+                        raise TypeError(msg.format(dtype=_dt))
                 if cond._mgr.any_extension_types:
                     # GH51574: avoid object ndarray conversion later on
                     cond = cond._constructor(

pandas/tests/frame/indexing/test_indexing.py

@@ -136,7 +136,7 @@ def test_getitem_boolean(self, mixed_float_frame, mixed_int_frame, datetime_fram
         subframe_obj = datetime_frame[indexer_obj]
         tm.assert_frame_equal(subframe_obj, subframe)
 
-        with pytest.raises(ValueError, match="Boolean array expected"):
+        with pytest.raises(TypeError, match="Boolean array expected"):
             datetime_frame[datetime_frame]
 
         # test that Series work

pandas/tests/frame/indexing/test_where.py

@@ -250,7 +250,7 @@ def test_where_invalid_input_single(self, cond):
         df = DataFrame({"a": [1, 2, 3]})
         msg = "Boolean array expected for the condition"
 
-        with pytest.raises(ValueError, match=msg):
+        with pytest.raises(TypeError, match=msg):
             df.where(cond)
 
     @pytest.mark.parametrize(
@@ -272,7 +272,7 @@ def test_where_invalid_input_multiple(self, cond):
         df = DataFrame({"a": [1, 2, 3], "b": [2, 2, 2]})
         msg = "Boolean array expected for the condition"
 
-        with pytest.raises(ValueError, match=msg):
+        with pytest.raises(TypeError, match=msg):
             df.where(cond)
 
     def test_where_dataframe_col_match(self):

pandas/tests/series/indexing/test_where.py

@@ -201,7 +201,7 @@ def test_where_invalid_input(cond):
     s = Series([1, 2, 3])
     msg = "Boolean array expected for the condition"
 
-    with pytest.raises(ValueError, match=msg):
+    with pytest.raises(TypeError, match=msg):
         s.where(cond)
 
     msg = "Array conditional must be same shape as self"