fix(UDPSocketReader): resolve security warnings reported by CodeQL

matejk · matejk · commit 043e44ece593 · 2024-03-27T00:37:06.000+01:00
diff --git a/Net/include/Poco/Net/UDPSocketReader.h b/Net/include/Poco/Net/UDPSocketReader.h
@@ -113,9 +113,9 @@ class UDPSocketReader
 			if (p)
 			{
 				Poco::UInt16 off = handler().payloadOffset();
-				auto* pAL = reinterpret_cast<poco_socklen_t*>(p + handler().addressLengthOffset());
+				pAL = reinterpret_cast<poco_socklen_t*>(p + handler().addressLengthOffset());
 				*pAL = SocketAddress::MAX_ADDRESS_LENGTH;
-				struct sockaddr* pSA = reinterpret_cast<struct sockaddr*>(p + handler().addressOffset());
+				pSA = reinterpret_cast<struct sockaddr*>(p + handler().addressOffset());
 				RT ret = sock.receiveFrom(p + off, S - off - 1, &pSA, &pAL);
 				if (ret < 0)
 				{

Original file line number	Diff line number	Diff line change
`@@ -113,9 +113,9 @@ class UDPSocketReader`
`113`	`113`	`if (p)`
`114`	`114`	`{`
`115`	`115`	`Poco::UInt16 off = handler().payloadOffset();`
`116`		`- auto* pAL = reinterpret_cast<poco_socklen_t*>(p + handler().addressLengthOffset());`
	`116`	`+ pAL = reinterpret_cast<poco_socklen_t*>(p + handler().addressLengthOffset());`
`117`	`117`	`*pAL = SocketAddress::MAX_ADDRESS_LENGTH;`
`118`		`- struct sockaddr* pSA = reinterpret_cast<struct sockaddr*>(p + handler().addressOffset());`
	`118`	`+ pSA = reinterpret_cast<struct sockaddr*>(p + handler().addressOffset());`
`119`	`119`	`RT ret = sock.receiveFrom(p + off, S - off - 1, &pSA, &pAL);`
`120`	`120`	`if (ret < 0)`
`121`	`121`	`{`