chore: refactored exceptions

Author: andrepimpao

docs/03-rules_choice.md

@@ -42,9 +42,6 @@ Validator::choice(['red', 'green', 'blue'], multiple: true, min: 2, max: 3)->val
 > [!NOTE]
 > An `UnexpectedValueException` will be thrown when `multiple` is `true` and the input value is not an `array`.
 
-> [!NOTE]
-> An `UnexpectedValueException` will be thrown when the `min` value is greater than or equal to the `max` value.
-
 ## Options
 
 ### `constraints`
@@ -106,7 +103,7 @@ The following parameters are available:
 
 ### `minMessage`
 
-type: `?string` default: `The {{ name }} value must have at least {{ min }} choices.`
+type: `?string` default: `The {{ name }} value must have at least {{ min }} choice(s).`
 
 Message that will be shown when `multiple` is `true` and input array has fewer values than the defined in `min`.
 
@@ -123,7 +120,7 @@ The following parameters are available:
 
 ### `maxMessage`
 
-type: `?string` default: `The {{ name }} value must have at most {{ max }} choices.`
+type: `?string` default: `The {{ name }} value must have at most {{ max }} choice(s).`
 
 Message that will be shown when `multiple` is `true` and input array has more values than the defined in `max`.
 

docs/03-rules_count.md

@@ -32,9 +32,6 @@ Validator::count(min: 3, max: 3)->validate(['a', 'b', 'c']); // true
 > [!NOTE]
 > An `UnexpectedValueException` will be thrown when either `min` or `max` options are not given.
 
-> [!NOTE]
-> An `UnexpectedValueException` will be thrown when the `min` value is greater than the `max` value.
-
 > [!NOTE]
 > An `UnexpectedValueException` will be thrown when the input value is not an `array` or an object implementing `\Countable`.
 

docs/03-rules_each-key.md

@@ -39,7 +39,7 @@ type: `?string` default: `Invalid key: {{ message }}`
 Message that will be shown if at least one input value key is invalid according to the given `validator`.
 
 ```php
-// throws: Invalid key: The color key value should be of type "string", 1 given.
+// throws: Invalid key 1: The value should be of type "string".
 Validator::eachKey(
     Validator::type('string')
 )->assert(['red' => '#f00', 1 => '#0f0'], 'color');

docs/03-rules_length.md

@@ -43,9 +43,6 @@ Validator::length(max: 1, countUnit: 'graphemes')->validate('🔥'); // true
 > [!NOTE]
 > An `UnexpectedValueException` will be thrown when either `min` or `max` options are not given.
 
-> [!NOTE]
-> An `UnexpectedValueException` will be thrown when the `min` value is greater than the `max` value.
-
 > [!NOTE]
 > An `UnexpectedValueException` will be thrown when the `charset` value is not a valid option.
 > Check all the supported character encodings [here](https://www.php.net/manual/en/mbstring.supported-encodings.php).
@@ -107,7 +104,7 @@ Validator::length(max: 3, normalizer: fn($value) => trim($value))->validate('abc
 
 ### `minMessage`
 
-type: `?string` default: `The {{ name }} value should have {{ min }} characters or more.`
+type: `?string` default: `The {{ name }} value should have {{ min }} character(s) or more.`
 
 Message that will be shown when the input value has fewer characters than the defined in `min`.
 
@@ -125,7 +122,7 @@ The following parameters are available:
 
 ### `maxMessage`
 
-type: `?string` default: `The {{ name }} value should have {{ max }} characters or less.`
+type: `?string` default: `The {{ name }} value should have {{ max }} character(s) or less.`
 
 Message that will be shown when the input value has more characters than the defined in `max`.
 

docs/03-rules_range.md

@@ -36,9 +36,6 @@ Validator::range(new DateTime('yesterday'), new DateTime('tomorrow'))->validate(
 > [!NOTE]
 > An `UnexpectedValueException` will be thrown when trying to compare incomparable values, like a `string` with an `int`.
 
-> [!NOTE]
-> An `UnexpectedValueException` will be thrown when the `min` value is greater than or equal to the `max` value.
-
 ## Options
 
 ### `min`

src/Exception/InvalidOptionException.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace ProgrammatorDev\Validator\Exception;
+
+class InvalidOptionException extends UnexpectedValueException
+{
+    public function __construct(string $name, string|array|null $expected = null)
+    {
+        $message = \sprintf('The "%s" option is not valid.', $name);
+
+        if (\is_array($expected)) {
+            $message = \sprintf('%s Accepted values are: "%s".', $message, \implode('", "', $expected));
+        }
+        else if (\is_string($expected)) {
+            $message = \sprintf('%s %s', $message, $expected);
+        }
+
+        parent::__construct($message);
+    }
+}

src/Exception/OptionDefinitionException.php

@@ -0,0 +1,5 @@
+<?php
+
+namespace ProgrammatorDev\Validator\Exception;
+
+class OptionDefinitionException extends UnexpectedValueException {}

src/Exception/UnexpectedComparableException.php

@@ -4,9 +4,13 @@
 
 class UnexpectedComparableException extends UnexpectedValueException
 {
-    public function __construct(string $value1, string $value2)
+    public function __construct(mixed $value1, mixed $value2)
     {
-        $message = \sprintf('Cannot compare a type "%s" with a type "%s".', $value1, $value2);
+        $message = \sprintf(
+            'Cannot compare a type "%s" with a type "%s".',
+            \get_debug_type($value1),
+            \get_debug_type($value2)
+        );
 
         parent::__construct($message);
     }

src/Exception/UnexpectedOptionException.php

@@ -12,10 +12,7 @@ abstract class AbstractComparisonRule extends AbstractRule
     public function assert(mixed $value, ?string $name = null): void
     {
         if (!$this->isComparable($value, $this->constraint)) {
-            throw new UnexpectedComparableException(
-                get_debug_type($value),
-                get_debug_type($this->constraint)
-            );
+            throw new UnexpectedComparableException($value, $this->constraint);
         }
 
         if (!$this->compareValues($value, $this->constraint)) {