Revert BUILD file change, remove bigint handling in writer.js

Author: pcj

BUILD.bazel

@@ -2,6 +2,10 @@
 #
 # See also code generation logic under generator/
 
+load("@rules_pkg//:mappings.bzl", "pkg_attributes", "pkg_files", "strip_prefix")
+load("@rules_pkg//:pkg.bzl", "pkg_tar", "pkg_zip")
+load("//:protobuf_javascript_release.bzl", "package_naming")
+
 config_setting(
     name = "x64_x86_windows",
     values = {"cpu": "x64_x86_windows"},
@@ -27,38 +31,65 @@ config_setting(
     values = {"cpu": "darwin_x86_64"},
 )
 
-filegroup(
-    name = "javascript",
+package_naming(
+    name = "protobuf_javascript_pkg_naming",
+    platform = select({
+        ":k8": "linux-x86_64", # currently the only supported build type in Github Actions
+        ":x64_x86_windows": "win32",
+        ":x64_windows": "win64",
+        ":darwin_arm64": "osx-aarch_64",
+        ":darwin_x86_64": "osx-x86_64",
+        "//conditions:default": "" # continues with current behavior when no --cpu is specified allowing existing internal builds to function
+    })
+)
+
+pkg_files(
+    name = "plugin_files",
+    srcs = ["//generator:protoc-gen-js"],
+    attributes = pkg_attributes(mode = "0555"),
+    prefix = "bin/",
+)
+
+pkg_files(
+    name = "dist_files",
+    srcs = glob([
+        "google/protobuf/*.js",
+        "google/protobuf/compiler/*.js"
+    ]) + [
+        "google-protobuf.js",
+        "package.json",
+        "README.md",
+        "LICENSE.md",
+        "LICENSE-asserts.md",
+    ],
+    strip_prefix = strip_prefix.from_root(""),
+)
+
+pkg_tar(
+    name = "dist_tar",
     srcs = [
-        "asserts.js",
-        "binary/any_field_type.js",
-        "binary/arith.js",
-        "binary/binary_constants.js",
-        "binary/bytesource.js",
-        "binary/bytesource_alias.js",
-        "binary/decoder.js",
-        "binary/decoder_alias.js",
-        "binary/encoder.js",
-        "binary/encoder_alias.js",
-        "binary/errors.js",
-        "binary/internal_buffer.js",
-        "binary/reader.js",
-        "binary/reader_alias.js",
-        "binary/repeated_field_type.js",
-        "binary/scalar_field_type.js",
-        "binary/test_utils.js",
-        "binary/utf8.js",
-        "binary/utils.js",
-        "binary/writer.js",
-        "binary/writer_alias.js",
-        "bytestring.js",
-        "debug.js",
-        "internal_bytes.js",
-        "internal_options.js",
-        "internal_public.js",
-        "map.js",
-        "message.js",
-        "unsafe_bytestring.js",
+        ":dist_files",
+        ":plugin_files",
     ],
-    visibility = ["//visibility:public"],
+    extension = "tar.gz",
+    package_file_name = "protobuf-javascript-{version}-{platform}.tar.gz",
+    package_variables = ":protobuf_javascript_pkg_naming",
+)
+
+pkg_zip(
+    name = "dist_zip",
+    srcs = [
+        ":dist_files",
+        ":plugin_files",
+    ],
+    package_file_name = "protobuf-javascript-{version}-{platform}.zip",
+    package_variables = ":protobuf_javascript_pkg_naming",
+)
+
+filegroup(
+    name = "dist_all",
+    srcs = [
+        ":dist_tar",
+        ":dist_zip",
+    ]
 )

binary/writer.js

@@ -430,10 +430,6 @@ class BinaryWriter {
         this.encoder_.writeZigzagVarint64(/** @type {number} */(value));
         break;
 
-      case 'bigint':
-        this.encoder_.writeZigzagVarint64BigInt(/** @type {bigint} */(value));
-        break;
-
       default:
         this.encoder_.writeZigzagVarint64String(/** @type {string} */(value));
         break;
@@ -1425,10 +1421,6 @@ class BinaryWriter {
           this.encoder_.writeZigzagVarint64(v);
           break;
 
-        case 'bigint':
-          this.encoder_.writeZigzagVarint64BigInt(/** @type {bigint} */(v));
-          break;
-
         default:
           this.encoder_.writeZigzagVarint64String(/** @type {string} */(v));
           break;