Cleanup and coverage

Author: kylekatarnls

examples/callback.js

@@ -0,0 +1,8 @@
+a = b => b * 2;
+b = function (c, d, e) {
+    return c + d(2) + e();
+};
+
+return b(2, a, function () {
+    return 8;
+});

examples/callback.return

@@ -0,0 +1 @@
+14

phpunit.xml

@@ -25,6 +25,7 @@
         <testsuite name="badSyntaxes">
             <file>tests/badSyntaxes.php</file>
             <file>tests/badSwitchSyntaxes.php</file>
+            <file>tests/badKeywordSyntaxes.php</file>
             <file>tests/unexpectedTokens.php</file>
             <file>tests/unexpectedTokensInBrackets.php</file>
             <file>tests/unexpectedTokensInHooks.php</file>

src/JsPhpize/Compiler/Compiler.php

@@ -127,7 +127,7 @@ function ($pair) use ($visitNode, $indent) {
         )));
     }
 
-    protected function visitConstant(Constant $constant, $indent)
+    protected function visitConstant(Constant $constant)
     {
         $value = $constant->value;
         if ($constant->type === 'string' && substr($constant->value, 0, 1) === '"') {

src/JsPhpize/Lexer/Scanner.php

@@ -38,11 +38,6 @@ public function scanConstant($matches)
         return $this->token('constant', $constant);
     }
 
-    public function scanFunction($matches)
-    {
-        return $this->valueToken('function', $matches);
-    }
-
     public function scanKeyword($matches)
     {
         return $this->valueToken('keyword', $matches);

src/JsPhpize/Nodes/Assignation.php

@@ -27,8 +27,6 @@ public function __construct($operator, Assignable $leftHand, Node $rightHand)
             throw new Exception($leftHand->getNonAssignableReason(), 9);
         }
 
-        $rightHand->mustBeAssignable();
-
         $this->operator = $operator;
         $this->leftHand = $leftHand;
         $this->rightHand = $rightHand;

src/JsPhpize/Nodes/Block.php

@@ -88,10 +88,6 @@ public function needParenthesis()
 
     public function addInstructions($instructions)
     {
-        if (!$this->handleInstructions()) {
-            throw new Exception($this->type . ' blocks cannot contains instructions.', 17);
-        }
-
         $instructions = is_array($instructions) ? $instructions : func_get_args();
         if (count($instructions)) {
             if (!$this->inInstruction) {
@@ -116,10 +112,6 @@ public function endInstruction()
 
     public function setValue(Value $value)
     {
-        if ($this->needParenthesis() && !($value instanceof Parenthesis)) {
-            throw new Exception($this->type . ' blocks need to be followed by a parenthesis.', 18);
-        }
-
         if ($this->type === 'for') {
             $value->setSeparator(';');
         }

src/JsPhpize/Nodes/BracketsArray.php

@@ -6,8 +6,6 @@ class BracketsArray extends ArrayBase
 {
     public function addItem(Constant $key, Node $value)
     {
-        $value->mustBeAssignable();
-
         $this->data[] = array($key, $value);
     }
 }

src/JsPhpize/Nodes/Instruction.php

@@ -13,15 +13,6 @@ class Instruction extends Node
 
     public function add($instruction)
     {
-        if (!is_object($instruction)) {
-            throw new Exception('An instance of Assignation or Value was expected, ' . gettype($instruction) . ' value type given.', 10);
-        }
-
-        if (!$instruction instanceof Value
-        && !$instruction instanceof Block) {
-            throw new Exception('An instance of Block or Value was expected, ' . get_class($instruction) . ' instance given.', 10);
-        }
-
         $this->instructions[] = $instruction;
     }
 }

src/JsPhpize/Nodes/Node.php

@@ -10,11 +10,4 @@ public function __get($name)
     {
         return $this->$name;
     }
-
-    public function mustBeAssignable()
-    {
-        if (!($this instanceof Value) && (!($this instanceof Block) || $this->type !== 'function')) {
-            throw new Exception('Only Value instance or Function block could be assigned.', 19);
-        }
-    }
 }