(maint) add expected private classes to unit tests

Author: h0tw1r3

spec/classes/mysql_backup_mysqldump_spec.rb

@@ -43,6 +43,8 @@ class { 'mysql::server': }
       context 'with defaults' do
         let(:params) { default_params }
 
+        it { is_expected.to contain_class('mysql::params') }
+
         it {
           expect(subject).to contain_cron('mysql-backup').with(
             command: '/usr/local/sbin/mysqlbackup.sh',

spec/classes/mysql_backup_xtrabackup_spec.rb

@@ -25,6 +25,8 @@ class { 'mysql::server': }
           default_params
         end
 
+        it { is_expected.to contain_class('mysql::params') }
+
         it 'does not contain the touch command' do
           expect(subject).to contain_file('xtrabackup.sh').without_content(
             %r{(^\s+touch\s+$)},

spec/classes/mysql_bindings_spec.rb

@@ -25,11 +25,27 @@
         }
       end
 
+      it { is_expected.to contain_class('mysql::params') }
+
+      it { is_expected.to contain_class('mysql::bindings::java') }
       it { is_expected.to contain_package('mysql-connector-java') }
+
+      it { is_expected.to contain_class('mysql::bindings::perl') }
       it { is_expected.to contain_package('perl_mysql') }
+
+      it { is_expected.to contain_class('mysql::bindings::python') }
       it { is_expected.to contain_package('python-mysqldb') }
+
+      it { is_expected.to contain_class('mysql::bindings::ruby') }
       it { is_expected.to contain_package('ruby_mysql') }
+
+      it { is_expected.to contain_class('mysql::bindings::php') }
+      it { is_expected.to contain_package('php-mysql') }
+
+      it { is_expected.to contain_class('mysql::bindings::client_dev') }
       it { is_expected.to contain_package('mysql-client_dev') }
+
+      it { is_expected.to contain_class('mysql::bindings::daemon_dev') }
       it { is_expected.to contain_package('mysql-daemon_dev') }
     end
   end

spec/classes/mysql_client_spec.rb

@@ -10,6 +10,8 @@
       end
 
       context 'with defaults' do
+        it { is_expected.to contain_class('mysql::params') }
+        it { is_expected.to contain_class('mysql::client::install') }
         it { is_expected.not_to contain_class('mysql::bindings') }
         it { is_expected.to contain_package('mysql_client') }
       end

spec/classes/mysql_params_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'mysql::params' do
+  on_supported_os.each do |os, facts|
+    context "on #{os}" do
+      let(:facts) { facts }
+
+      it { is_expected.to compile }
+    end
+  end
+end

spec/classes/mysql_server_backup_spec.rb

@@ -27,6 +27,8 @@ class { 'mysql::server': }
       context 'standard conditions' do
         let(:params) { default_params }
 
+        it { is_expected.to contain_class('mysql::params') }
+
         # Cannot use that_requires here, doesn't work on classes.
         it {
           expect(subject).to contain_mysql_user('testuser@localhost').with(

spec/classes/mysql_server_spec.rb

@@ -10,8 +10,11 @@
       end
 
       context 'with defaults' do
+        it { is_expected.to contain_class('mysql::params') }
         it { is_expected.to contain_class('mysql::server::install') }
         it { is_expected.to contain_class('mysql::server::config') }
+        it { is_expected.to contain_class('mysql::server::managed_dirs') }
+        it { is_expected.to contain_class('mysql::server::installdb') }
         it { is_expected.to contain_class('mysql::server::service') }
         it { is_expected.to contain_class('mysql::server::root_password') }
         it { is_expected.to contain_class('mysql::server::providers') }