top-scope facts

Author: LukasAud

.puppet-lint.rc

@@ -1,4 +1,3 @@
 --relative
---no-top_scope_facts-check
 --no-anchor_resource-check
 --no-params_empty_string_assignment-check

.sync.yml

@@ -36,6 +36,5 @@ Rakefile:
 changelog_since_tag: 'v11.0.3'
 Rakefile:
   extra_disabled_lint_checks:
-    - top_scope_facts
     - anchor_resource
     - params_empty_string_assignment

Rakefile

@@ -42,7 +42,6 @@ def changelog_future_release
 end
 
 PuppetLint.configuration.send('disable_relative')
-PuppetLint.configuration.send('disable_top_scope_facts')
 PuppetLint.configuration.send('disable_anchor_resource')
 PuppetLint.configuration.send('disable_params_empty_string_assignment')
 

examples/monitor.pp

@@ -3,7 +3,7 @@
 
 $mysql_monitor_password = 'password'
 $mysql_monitor_username = 'monitoring'
-$mysql_monitor_hostname = $::facts['networking']['hostname']
+$mysql_monitor_hostname = $facts['networking']['hostname']
 
 mysql_user { "${mysql_monitor_username}@${mysql_monitor_hostname}":
   ensure        => present,

manifests/bindings.pp

@@ -25,43 +25,50 @@
 # @param daemon_dev
 #   Specifies whether `::mysql::bindings::daemon_dev` should be included. Valid values are `true`, `false`.
 # @param java_package_ensure
-#   Whether the package should be present, absent, or a specific version. Valid values are 'present', 'absent', or 'x.y.z'. Only applies if `java_enable => true`.
+#   Whether the package should be present, absent, or a specific version. Valid values are 'present', 'absent', or 'x.y.z'. 
+#   Only applies if `java_enable => true`.
 # @param java_package_name
 #   The name of the Java package to install. Only applies if `java_enable => true`.
 # @param java_package_provider
 #   The provider to use to install the Java package. Only applies if `java_enable => true`.
 # @param perl_package_ensure
-#   Whether the package should be present, absent, or a specific version. Valid values are 'present', 'absent', or 'x.y.z'. Only applies if `perl_enable => true`.
+#   Whether the package should be present, absent, or a specific version. Valid values are 'present', 'absent', or 'x.y.z'. 
+#   Only applies if `perl_enable => true`.
 # @param perl_package_name
 #   The name of the Perl package to install. Only applies if `perl_enable => true`.
 # @param perl_package_provider
 #   The provider to use to install the Perl package. Only applies if `perl_enable => true`.
 # @param php_package_ensure
-#   Whether the package should be present, absent, or a specific version. Valid values are 'present', 'absent', or 'x.y.z'. Only applies if `php_enable => true`.
+#   Whether the package should be present, absent, or a specific version. Valid values are 'present', 'absent', or 'x.y.z'. 
+#   Only applies if `php_enable => true`.
 # @param php_package_name
 #   The name of the PHP package to install. Only applies if `php_enable => true`.
 # @param php_package_provider
 #   The provider to use to install the PHP package. Only applies if `php_enable => true`.
 # @param python_package_ensure
-#   Whether the package should be present, absent, or a specific version. Valid values are 'present', 'absent', or 'x.y.z'. Only applies if `python_enable => true`.
+#   Whether the package should be present, absent, or a specific version. Valid values are 'present', 'absent', or 'x.y.z'. 
+#   Only applies if `python_enable => true`.
 # @param python_package_name
 #   The name of the Python package to install. Only applies if `python_enable => true`.
 # @param python_package_provider
 #   The provider to use to install the Python package. Only applies if `python_enable => true`.
 # @param ruby_package_ensure
-#   Whether the package should be present, absent, or a specific version. Valid values are 'present', 'absent', or 'x.y.z'. Only applies if `ruby_enable => true`.
+#   Whether the package should be present, absent, or a specific version. Valid values are 'present', 'absent', or 'x.y.z'. 
+#   Only applies if `ruby_enable => true`.
 # @param ruby_package_name
 #   The name of the Ruby package to install. Only applies if `ruby_enable => true`.
 # @param ruby_package_provider
 #   What provider should be used to install the package.
 # @param client_dev_package_ensure
-#   Whether the package should be present, absent, or a specific version. Valid values are 'present', 'absent', or 'x.y.z'. Only applies if `client_dev => true`.
+#   Whether the package should be present, absent, or a specific version. Valid values are 'present', 'absent', or 'x.y.z'. 
+#   Only applies if `client_dev => true`.
 # @param client_dev_package_name
 #   The name of the client_dev package to install. Only applies if `client_dev => true`.
 # @param client_dev_package_provider
 #   The provider to use to install the client_dev package. Only applies if `client_dev => true`.
 # @param daemon_dev_package_ensure
-#   Whether the package should be present, absent, or a specific version. Valid values are 'present', 'absent', or 'x.y.z'. Only applies if `daemon_dev => true`.
+#   Whether the package should be present, absent, or a specific version. Valid values are 'present', 'absent', or 'x.y.z'. 
+#   Only applies if `daemon_dev => true`.
 # @param daemon_dev_package_name
 #   The name of the daemon_dev package to install. Only applies if `daemon_dev => true`.
 # @param daemon_dev_package_provider
@@ -102,11 +109,11 @@
 ) inherits mysql::params {
   case $facts['os']['family'] {
     'Archlinux': {
-      if $java_enable { fail("::mysql::bindings::java cannot be managed by puppet on ${::facts['os']['family']} as it is not in official repositories. Please disable java mysql binding.") }
+      if $java_enable { fail("::mysql::bindings::java cannot be managed by puppet on ${facts['os']['family']} as it is not in official repositories. Please disable java mysql binding.") }
       if $perl_enable { include 'mysql::bindings::perl' }
-      if $php_enable { warning("::mysql::bindings::php does not need to be managed by puppet on ${::facts['os']['family']} as it is included in mysql package by default.") }
+      if $php_enable { warning("::mysql::bindings::php does not need to be managed by puppet on ${facts['os']['family']} as it is included in mysql package by default.") }
       if $python_enable { include 'mysql::bindings::python' }
-      if $ruby_enable { fail("::mysql::bindings::ruby cannot be managed by puppet on ${::facts['os']['family']} as it is not in official repositories. Please disable ruby mysql binding.") }
+      if $ruby_enable { fail("::mysql::bindings::ruby cannot be managed by puppet on ${facts['os']['family']} as it is not in official repositories. Please disable ruby mysql binding.") }
     }
 
     default: {

manifests/db.pp

@@ -126,7 +126,7 @@
       exec { "${dbname}-import":
         command     => "${import_cat_cmd} ${shell_join($sql)} | mysql ${dbname}",
         logoutput   => true,
-        environment => "HOME=${::root_home}",
+        environment => "HOME=${facts['root_home']}",
         refreshonly => ! $enforce_sql,
         path        => "/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:${_mysql_exec_path}",
         require     => Mysql_grant["${user}@${host}/${table}"],

manifests/server.pp

@@ -20,7 +20,8 @@
 # @param manage_config_file
 #   Whether the MySQL configuration file should be managed. Valid values are `true`, `false`. Defaults to `true`.
 # @param options
-#   A hash of options structured like the override_options, but not merged with the default options. Use this if you don't want your options merged with the default options.
+#   A hash of options structured like the override_options, but not merged with the default options. 
+#   Use this if you don't want your options merged with the default options.
 # @param override_options
 #   Specifies override options to pass into MySQL. Structured like a hash in the my.cnf file:  See  above for usage details.
 # @param package_ensure
@@ -50,7 +51,11 @@
 # @param mycnf_group
 #   Name or group-id which owns the mysql-config-file.
 # @param root_password
-#   The MySQL root password. Puppet attempts to set the root password and update `/root/.my.cnf` with it. This is required if `create_root_user` or `create_root_my_cnf` are true. If `root_password` is 'UNSET', then `create_root_user` and `create_root_my_cnf` are assumed to be false --- that is, the MySQL root user and `/root/.my.cnf` are not created. Password changes are supported; however, the old password must be set in `/root/.my.cnf`. Effectively, Puppet uses the old password, configured in `/root/my.cnf`, to set the new password in MySQL, and then updates `/root/.my.cnf` with the new password.
+#   The MySQL root password. Puppet attempts to set the root password and update `/root/.my.cnf` with it. This is required 
+#   if `create_root_user` or `create_root_my_cnf` are true. If `root_password` is 'UNSET', then `create_root_user` and 
+#   `create_root_my_cnf` are assumed to be false --- that is, the MySQL root user and `/root/.my.cnf` are not created. 
+#   Password changes are supported; however, the old password must be set in `/root/.my.cnf`. Effectively, Puppet uses the old 
+#   password, configured in `/root/my.cnf`, to set the new password in MySQL, and then updates `/root/.my.cnf` with the new password.
 # @param service_enabled
 #   Specifies whether the service should be enabled. Valid values are `true`, `false`. Defaults to `true`.
 # @param service_manage
@@ -60,9 +65,13 @@
 # @param service_provider
 #   The provider to use to manage the service. For Ubuntu, defaults to 'upstart'; otherwise, default is undefined.
 # @param create_root_user
-#   Whether root user should be created. Valid values are `true`, `false`. Defaults to `true`. This is useful for a cluster setup with Galera. The root user has to be created only once. You can set this parameter true on one node and set it to false on the remaining nodes.
+#   Whether root user should be created. Valid values are `true`, `false`. Defaults to `true`. 
+#   This is useful for a cluster setup with Galera. The root user has to be created only once. 
+#   You can set this parameter true on one node and set it to false on the remaining nodes.
 # @param create_root_my_cnf
-#   Whether to create `/root/.my.cnf`. Valid values are `true`, `false`. Defaults to `true`. `create_root_my_cnf` allows creation of `/root/.my.cnf` independently of `create_root_user`. You can use this for a cluster setup with Galera where you want `/root/.my.cnf` to exist on all nodes.
+#   Whether to create `/root/.my.cnf`. Valid values are `true`, `false`. Defaults to `true`. 
+#   `create_root_my_cnf` allows creation of `/root/.my.cnf` independently of `create_root_user`. 
+#   You can use this for a cluster setup with Galera where you want `/root/.my.cnf` to exist on all nodes.
 # @param create_root_login_file
 #   Whether to create a login file for root. Valid values are 'true', 'false'.
 # @param login_file
@@ -78,7 +87,8 @@
 # @param manage_service
 #   _Deprecated_
 # @param old_root_password
-#   This parameter no longer does anything. It exists only for backwards compatibility. See the `root_password` parameter above for details on changing the root password.
+#   This parameter no longer does anything. It exists only for backwards compatibility. 
+#   See the `root_password` parameter above for details on changing the root password.
 #
 class mysql::server (
   String[1]                                                             $config_file             = $mysql::params::config_file,

manifests/server/backup.pp

@@ -45,7 +45,8 @@
 # @param ignore_events
 #   Ignore the mysql.event table.
 # @param delete_before_dump
-#   Whether to delete old .sql files before backing up. Setting to true deletes old files before backing up, while setting to false deletes them after backup.
+#   Whether to delete old .sql files before backing up. 
+#   Setting to true deletes old files before backing up, while setting to false deletes them after backup.
 # @param backupdatabases
 #   Databases to backup (required if using xtrabackup provider). By default `[]` will back up all databases.
 # @param file_per_database
@@ -62,15 +63,18 @@
 # @param prescript
 #   A script that is executed before the backup begins.
 # @param postscript
-#   A script that is executed when the backup is finished. This could be used to sync the backup to a central store. This script can be either a single line that is directly executed or a number of lines supplied as an array. It could also be one or more externally managed (executable) files.
+#   A script that is executed when the backup is finished. This could be used to sync the backup to a central store. 
+#   This script can be either a single line that is directly executed or a number of lines supplied as an array. 
+#   It could also be one or more externally managed (executable) files.
 # @param execpath
 #   Allows you to set a custom PATH should your MySQL installation be non-standard places. Defaults to `/usr/bin:/usr/sbin:/bin:/sbin`.
 # @param provider
 #   Sets the server backup implementation. Valid values are: xtrabackup, mysqldump, mysqlbackup
 # @param maxallowedpacket
 #   Defines the maximum SQL statement size for the backup dump script. The default value is 1MB, as this is the default MySQL Server value.
 # @param optional_args
-#   Specifies an array of optional arguments which should be passed through to the backup tool. (Supported by the xtrabackup and mysqldump providers.)
+#   Specifies an array of optional arguments which should be passed through to the backup tool. 
+#   (Supported by the xtrabackup and mysqldump providers.)
 # @param install_cron
 #   Manage installation of cron package
 # @param compression_command

manifests/server/root_password.pp

@@ -39,23 +39,23 @@
 
   if $mysql::server::create_root_my_cnf and $root_password_set {
     # TODO: use EPP instead of ERB, as EPP can handle Data of Type Sensitive without further ado
-    file { "${::root_home}/.my.cnf":
+    file { "${facts['root_home']}/.my.cnf":
       content => template('mysql/my.cnf.pass.erb'),
       owner   => 'root',
       mode    => '0600',
     }
 
     # show_diff was added with puppet 3.0
-    if versioncmp($::puppetversion, '3.0') >= 0 {
-      File["${::root_home}/.my.cnf"] { show_diff => false }
+    if versioncmp($facts['puppetversion'], '3.0') >= 0 {
+      File["${facts['root_home']}/.my.cnf"] { show_diff => false }
     }
     if $mysql::server::create_root_user {
-      Mysql_user['root@localhost'] -> File["${::root_home}/.my.cnf"]
+      Mysql_user['root@localhost'] -> File["${facts['root_home']}/.my.cnf"]
     }
   }
 
   if $mysql::server::create_root_login_file and $root_password_set {
-    file { "${::root_home}/.mylogin.cnf":
+    file { "${facts['root_home']}/.mylogin.cnf":
       source => $login_file,
       owner  => 'root',
       mode   => '0600',