RHEL9 Fixes

Prior to this commit, xtrabackup acceptance tests would fail when the
OS was RHEL 9. This is because xtrabackup is not currently supported for
RHEL 9.

This commit moves the xtrabackup acceptance tests in to their own
spec file and adds conditions to the tests that ensure they are only
executed on supported OSes.

Author: chelnak

spec/acceptance/04_mysql_backup_spec.rb

@@ -129,213 +129,4 @@ class { 'mysql::server::backup':
       end
     end
   end
-
-  context 'with xtrabackup enabled' do
-    context 'should work with no errors', if: ((os[:family] == 'debian') || (os[:family] == 'ubuntu') || (os[:family] == 'redhat' && os[:release].to_i > 7)) do
-      pp = <<-MANIFEST
-          class { 'mysql::server': root_password => 'password' }
-          mysql::db { [
-            'backup1',
-            'backup2'
-          ]:
-            user     => 'backup',
-            password => 'secret',
-            charset  => '#{fetch_charset}',
-            collate  => '#{fetch_charset}_general_ci',
-          }
-          case $facts['os']['family'] {
-            /Debian/: {
-              $source_url = "http://repo.percona.com/apt/percona-release_latest.${facts['os']['distro']['codename']}_all.deb"
-
-              file { '/tmp/percona-release_latest.deb':
-                ensure  => present,
-                source  => $source_url,
-              }
-              ensure_packages('gnupg')
-              ensure_packages('gnupg2')
-              ensure_packages('curl')
-              ensure_packages('percona-release',{
-                ensure   => present,
-                provider => 'dpkg',
-                source   => '/tmp/percona-release_latest.deb',
-                notify   => Exec['apt-get update'],
-              })
-              exec { 'apt-get update':
-                path        => '/usr/bin:/usr/sbin:/bin:/sbin',
-                refreshonly => true,
-              }
-            }
-            /RedHat/: {
-              # RHEL/CentOS 5 is no longer supported by Percona, but older versions
-              # of the repository are still available.
-              if versioncmp($::operatingsystemmajrelease, '6') >= 0 {
-                $percona_url = 'http://repo.percona.com/yum/percona-release-latest.noarch.rpm'
-                $epel_url = "https://download.fedoraproject.org/pub/epel/epel-release-latest-${facts['os']['release']['major']}.noarch.rpm"
-              } else {
-                $percona_url = 'http://repo.percona.com/yum/release/5/os/noarch/percona-release-0.1-3.noarch.rpm'
-                $epel_url = 'https://archives.fedoraproject.org/pub/archive/epel/epel-release-latest-5.noarch.rpm'
-              }
-              ensure_packages('percona-release',{
-                ensure   => present,
-                provider => 'rpm',
-                source   => $percona_url,
-              })
-              ensure_packages('epel-release',{
-                ensure   => present,
-                provider => 'rpm',
-                source   => $epel_url,
-              })
-              if ($facts['os']['name'] == 'Scientific') {
-                # $releasever resolves to '6.10' instead of '6' which breaks Percona repos
-                file { '/etc/yum/vars/releasever':
-                  ensure  => present,
-                  content => '6',
-                }
-              }
-            }
-            default: { }
-          }
-          class { 'mysql::server::backup':
-            backupuser     => 'myuser',
-            backuppassword => 'mypassword',
-            backupdir      => '/tmp/xtrabackups',
-            provider       => 'xtrabackup',
-            execpath       => '/usr/bin:/usr/sbin:/bin:/sbin:/opt/zimbra/bin',
-          }
-      MANIFEST
-      it 'when configuring mysql backup' do
-        idempotent_apply(pp)
-      end
-    end
-
-    describe 'xtrabackup.sh', if: Gem::Version.new(mysql_version) < Gem::Version.new('5.7.0') && ((os[:family] == 'debian' && os[:release].to_i >= 9) || (os[:family] == 'ubuntu') || (os[:family] == 'redhat' && os[:release].to_i > 7)) do # rubocop:disable Layout/LineLength
-      it 'runs xtrabackup.sh full backup with no errors' do
-        run_shell('/usr/local/sbin/xtrabackup.sh --target-dir=/tmp/xtrabackups/$(date +%F)_full --backup 2>&1 | tee /tmp/xtrabackup_full.log') do |r|
-          expect(r.exit_code).to be_zero
-        end
-      end
-
-      it 'xtrabackup reports success for the full backup' do
-        # NOTE: Once support for CentOS 6 is dropped, we should check for "completed OK" instead.
-        run_shell('grep "xtrabackup: Transaction log of lsn" /tmp/xtrabackup_full.log') do |r|
-          expect(r.exit_code).to be_zero
-        end
-      end
-
-      it 'creates a subdirectory for the full backup' do
-        run_shell('find /tmp/xtrabackups -mindepth 1 -maxdepth 1 -type d -name $(date +%Y)\*full | wc -l') do |r|
-          expect(r.stdout).to match(%r{1})
-          expect(r.exit_code).to be_zero
-        end
-      end
-
-      it 'runs xtrabackup.sh incremental backup with no errors' do
-        run_shell('sleep 1')
-        run_shell('/usr/local/sbin/xtrabackup.sh --incremental-basedir=/tmp/xtrabackups/$(date +%F)_full --target-dir=/tmp/xtrabackups/$(date +%F_%H-%M-%S) --backup 2>&1 | tee /tmp/xtrabackup_inc.log') do |r| # rubocop:disable Layout/LineLength
-          expect(r.exit_code).to be_zero
-        end
-      end
-
-      it 'xtrabackup reports success for the incremental backup' do
-        # NOTE: Once support for CentOS 6 is dropped, we should check for "completed OK" instead.
-        run_shell('grep "xtrabackup: Transaction log of lsn" /tmp/xtrabackup_inc.log') do |r|
-          expect(r.exit_code).to be_zero
-        end
-      end
-
-      it 'creates a new subdirectory for each backup' do
-        run_shell('find /tmp/xtrabackups -mindepth 1 -maxdepth 1 -type d -name $(date +%Y)\* | wc -l') do |r|
-          expect(r.stdout).to match(%r{2})
-          expect(r.exit_code).to be_zero
-        end
-      end
-    end
-  end
-
-  context 'with xtrabackup enabled and incremental backups disabled' do
-    context 'should work with no errors', if: ((os[:family] == 'debian') || (os[:family] == 'ubuntu') || (os[:family] == 'redhat' && os[:release].to_i > 7)) do
-      pp = <<-MANIFEST
-          class { 'mysql::server': root_password => 'password' }
-          mysql::db { [
-            'backup1',
-            'backup2'
-          ]:
-            user     => 'backup',
-            password => 'secret',
-            charset  => '#{fetch_charset}',
-            collate  => '#{fetch_charset}_general_ci',
-          }
-          case $facts['os']['family'] {
-            /Debian/: {
-              $source_url = "http://repo.percona.com/apt/percona-release_1.0-22.generic_all.deb"
-
-              file { '/tmp/percona-release_latest.deb':
-                ensure => present,
-                source => $source_url,
-              }
-              ensure_packages('gnupg')
-              ensure_packages('gnupg2')
-              ensure_packages('percona-release',{
-                ensure   => present,
-                provider => 'dpkg',
-                source   => '/tmp/percona-release_latest.deb',
-                notify   => Exec['apt-get update'],
-              })
-              exec { 'apt-get update':
-                path        => '/usr/bin:/usr/sbin:/bin:/sbin',
-                refreshonly => true,
-              }
-            }
-            /RedHat/: {
-              $percona_url = 'http://repo.percona.com/yum/percona-release-latest.noarch.rpm'
-              $epel_url = "https://download.fedoraproject.org/pub/epel/epel-release-latest-${facts['os']['release']['major']}.noarch.rpm"
-              ensure_packages('percona-release',{
-                ensure   => present,
-                provider => 'rpm',
-                source   => $percona_url,
-              })
-              ensure_packages('epel-release',{
-                ensure   => present,
-                provider => 'rpm',
-                source   => $epel_url,
-              })
-              if ($facts['os']['name'] == 'Scientific') {
-                # $releasever resolves to '6.10' instead of '6' which breaks Percona repos
-                file { '/etc/yum/vars/releasever':
-                  ensure  => present,
-                  content => '6',
-                }
-              }
-            }
-            default: { }
-          }
-          class { 'mysql::server::backup':
-            backupuser          => 'myuser',
-            backuppassword      => 'mypassword',
-            backupdir           => '/tmp/xtrabackups',
-            provider            => 'xtrabackup',
-            incremental_backups => false,
-            execpath            => '/usr/bin:/usr/sbin:/bin:/sbin:/opt/zimbra/bin',
-          }
-      MANIFEST
-      it 'when configuring mysql backup' do
-        idempotent_apply(pp)
-      end
-    end
-
-    describe 'xtrabackup.sh', if: Gem::Version.new(mysql_version) < Gem::Version.new('5.7.0') && ((os[:family] == 'debian' && os[:release].to_i >= 9) || (os[:family] == 'ubuntu') || (os[:family] == 'redhat' && os[:release].to_i > 7)) do # rubocop:disable Layout/LineLength
-      it 'runs xtrabackup.sh with no errors' do
-        run_shell('/usr/local/sbin/xtrabackup.sh --target-dir=/tmp/xtrabackups/$(date +%F_%H-%M-%S) --backup 2>&1 | tee /tmp/xtrabackup.log') do |r|
-          expect(r.exit_code).to be_zero
-        end
-      end
-
-      it 'xtrabackup reports success for the backup' do
-        # NOTE: Once support for CentOS 6 is dropped, we should check for "completed OK" instead.
-        run_shell('grep "xtrabackup: Transaction log of lsn" /tmp/xtrabackup.log') do |r|
-          expect(r.exit_code).to be_zero
-        end
-      end
-    end
-  end
 end