(CONT-789) Rubocop Manual Fix 5 - Naming/MethodParameterName

Author: david22swan

.rubocop_todo.yml

@@ -55,14 +55,6 @@ Naming/MemoizedInstanceVariableName:
   Exclude:
     - 'spec/spec_helper_acceptance_local.rb'
 
-# Offense count: 2
-# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: as, at, by, cc, db, id, if, in, io, ip, of, on, os, pp, to
-Naming/MethodParameterName:
-  Exclude:
-    - 'lib/puppet/provider/mysql_login_path/mysql_login_path.rb'
-    - 'lib/puppet/type/mysql_user.rb'
-
 # Offense count: 24
 # Configuration parameters: MinSize.
 Performance/CollectionLiteralInLoop:

lib/puppet/provider/mysql_login_path/mysql_login_path.rb

@@ -105,8 +105,8 @@ def delete_login_path(context, name)
     mysql_config_editor_cmd(context, uid, 'remove', '-G', login_path)
   end
 
-  def gen_pw(pw)
-    Puppet::Provider::MysqlLoginPath::Sensitive.new(pw)
+  def gen_pw(password)
+    Puppet::Provider::MysqlLoginPath::Sensitive.new(password)
   end
 
   def extract_pw(sensitive)

lib/puppet/type/mysql_user.rb

@@ -102,13 +102,13 @@ def should_to_s(_newvalue)
         end
       end
     end
-    def insync?(is)
+    def insync?(insync)
       # The current value may be nil and we don't
       # want to call sort on it so make sure we have arrays
-      if is.is_a?(Array) && @should.is_a?(Array)
-        is.sort == @should.sort
+      if insync.is_a?(Array) && @should.is_a?(Array)
+        insync.sort == @should.sort
       else
-        is == @should
+        insync == @should
       end
     end
   end