(CONT-789) Rubocop Manual Fix 4 - Style/OptionalBooleanParameter

Author: david22swan

.rubocop_todo.yml

@@ -141,11 +141,3 @@ Style/MixinUsage:
   Exclude:
     - 'spec/spec_helper.rb'
     - 'spec/spec_helper_local.rb'
-
-# Offense count: 2
-# Configuration parameters: AllowedMethods.
-# AllowedMethods: respond_to_missing?
-Style/OptionalBooleanParameter:
-  Exclude:
-    - 'lib/puppet/functions/mysql/password.rb'
-    - 'lib/puppet/functions/mysql_password.rb'

lib/puppet/functions/mysql/password.rb

@@ -19,7 +19,7 @@
     return_type 'Variant[String, Sensitive[String]]'
   end
 
-  def password(password, sensitive = false)
+  def password(password, sensitive: false)
     password = password.unwrap if password.is_a?(Puppet::Pops::Types::PSensitiveType::Sensitive)
 
     result_string = if %r{\*[A-F0-9]{40}$}.match?(password)

lib/puppet/functions/mysql_password.rb

@@ -15,7 +15,7 @@
     return_type 'Variant[String, Sensitive[String]]'
   end
 
-  def mysql_password(password, sensitive = false)
+  def mysql_password(password, sensitive: false)
     call_function('deprecation', 'mysql_password', "This method has been deprecated, please use the namespaced version 'mysql::password' instead.")
     call_function('mysql::password', password, sensitive)
   end