Perez coeff ModelChain example #2148
Conversation
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
Nice @bgpierc, this is great! A few small suggestions below.
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
LGTM, thanks @bgpierc!
I'll plan to merge this in a few days to give others a chance to review if they want.
cwhanse
left a comment
cwhanse
left a comment
There was a problem hiding this comment.
Some suggested edits for clarity.
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
echedey-ls
left a comment
echedey-ls
left a comment
There was a problem hiding this comment.
LGTM.
Btw, was this comment not addressed due to any reason I (probably we) ignore?
AdamRJensen
left a comment
AdamRJensen
left a comment
There was a problem hiding this comment.
Minior comments, but looks good :)
| 'wind_speed': tmy['wind_speed']}) | ||
|
|
||
| loc = location.Location.from_tmy(metadata) | ||
|
|
There was a problem hiding this comment.
I'm inclined to break the code block in two at this point, just to make it less overwhelming to users. This can be done by adding in a sentence saying something like "Next, we set up a standard PV model using ModelChain".
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
|
Thanks @bgpierc! |
5 participants
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.This PR adds an example of using different Perez coefficients in a
ModelChainas discussed in #2127. I wasn't sure where to put it so I stuck it in the irradiance transposition sectionRendering of the gallery example